From 2a9a35367c440a9814447942a85dfed9c251566f Mon Sep 17 00:00:00 2001
From: Advay Tandon <82980589+advay26@users.noreply.github.com>
Date: Thu, 6 Apr 2023 11:37:34 -0700
Subject: [PATCH] [A11y] Fix Framework filter tooltip's confusing double
 behavior (#9454)

* Fixed tooltip's confusing double behavior (kinda)

* removed extra tab index
---
 src/NuGetGallery/Scripts/gallery/page-list-packages.js | 1 -
 src/NuGetGallery/Strings.Designer.cs                   | 9 ---------
 src/NuGetGallery/Strings.resx                          | 3 ---
 src/NuGetGallery/ViewModels/PackageListViewModel.cs    | 2 +-
 src/NuGetGallery/Views/Shared/ListPackages.cshtml      | 6 ++----
 5 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/src/NuGetGallery/Scripts/gallery/page-list-packages.js b/src/NuGetGallery/Scripts/gallery/page-list-packages.js
index 640c76ca60..c3e682f196 100644
--- a/src/NuGetGallery/Scripts/gallery/page-list-packages.js
+++ b/src/NuGetGallery/Scripts/gallery/page-list-packages.js
@@ -2,7 +2,6 @@ $(function() {
     'use strict';
 
     $(".reserved-indicator").each(window.nuget.setPopovers);
-    $(".framework-filter-info-icon").each(window.nuget.setPopovers);
 
     const searchForm = document.forms.search;
     const allFrameworks = document.querySelectorAll('.framework');
diff --git a/src/NuGetGallery/Strings.Designer.cs b/src/NuGetGallery/Strings.Designer.cs
index eb6aaf6c4b..f2e548d328 100644
--- a/src/NuGetGallery/Strings.Designer.cs
+++ b/src/NuGetGallery/Strings.Designer.cs
@@ -1102,15 +1102,6 @@ public static string ForgotPassword_Disabled_Error {
             }
         }
         
-        /// <summary>
-        ///   Looks up a localized string similar to Filters packages based on the target frameworks included in the NuGet Package..
-        /// </summary>
-        public static string FrameworkFilterInformation_Tooltip {
-            get {
-                return ResourceManager.GetString("FrameworkFilterInformation_Tooltip", resourceCulture);
-            }
-        }
-        
         /// <summary>
         ///   Looks up a localized string similar to The API key &apos;{0}&apos; is invalid..
         /// </summary>
diff --git a/src/NuGetGallery/Strings.resx b/src/NuGetGallery/Strings.resx
index f515658d62..f337eccb71 100644
--- a/src/NuGetGallery/Strings.resx
+++ b/src/NuGetGallery/Strings.resx
@@ -1254,7 +1254,4 @@ The {1} Team</value>
   <data name="ForgotPassword_Disabled_Error" xml:space="preserve">
     <value>Forgot password is disabled.</value>
   </data>
-  <data name="FrameworkFilterInformation_Tooltip" xml:space="preserve">
-    <value>Filters packages based on the target frameworks included in the NuGet Package.</value>
-  </data>
 </root>
\ No newline at end of file
diff --git a/src/NuGetGallery/ViewModels/PackageListViewModel.cs b/src/NuGetGallery/ViewModels/PackageListViewModel.cs
index 1e1f5ca0fd..512d30e07b 100644
--- a/src/NuGetGallery/ViewModels/PackageListViewModel.cs
+++ b/src/NuGetGallery/ViewModels/PackageListViewModel.cs
@@ -84,6 +84,6 @@ public PackageListViewModel(
 
         public Dictionary<string, FrameworkFilterHelper.FrameworkFilterGroup> FrameworkFilters = FrameworkFilterHelper.FrameworkFilters;
 
-        public string TargetFrameworkInformationLink = "https://learn.microsoft.com/en-us/dotnet/standard/frameworks";
+        public string FrameworksFilteringInformationLink = "https://learn.microsoft.com/nuget/consume-packages/finding-and-choosing-packages#advanced-filtering-and-sorting";
     }
 }
\ No newline at end of file
diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
index 294e771d32..c603f55c1e 100644
--- a/src/NuGetGallery/Views/Shared/ListPackages.cshtml
+++ b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
@@ -82,10 +82,8 @@
                                 <fieldset id="frameworkfilters">
                                     <legend>
                                         Frameworks
-                                        <a href="@(Model.TargetFrameworkInformationLink)" title="Frameworks filter information">
-                                            <i class="framework-filter-info-icon ms-Icon ms-Icon--Info" tabindex="0"
-                                               data-content="@Strings.FrameworkFilterInformation_Tooltip"
-                                               alt="@Strings.FrameworkFilterInformation_Tooltip"></i>
+                                        <a href="@(Model.FrameworksFilteringInformationLink)" title="Filters packages based on the target frameworks included in the NuGet Package. Click here to learn more.">
+                                            <i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
                                         </a>
                                     </legend>
                                     @foreach (var framework in Model.FrameworkFilters.Values)