[A11y] Fix Framework filter tooltip's confusing double behavior (#9454)

* Fixed tooltip's confusing double behavior (kinda) * removed extra tab index
NuGet · Apr 6, 2023 · 2a9a353 · 2a9a353
1 parent 32e13ba
commit 2a9a353
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 18 deletions.
diff --git a/src/NuGetGallery/Scripts/gallery/page-list-packages.js b/src/NuGetGallery/Scripts/gallery/page-list-packages.js
@@ -2,7 +2,6 @@ $(function() {
     'use strict';
 
     $(".reserved-indicator").each(window.nuget.setPopovers);
-    $(".framework-filter-info-icon").each(window.nuget.setPopovers);
 
     const searchForm = document.forms.search;
     const allFrameworks = document.querySelectorAll('.framework');

diff --git a/src/NuGetGallery/Strings.Designer.cs b/src/NuGetGallery/Strings.Designer.cs
diff --git a/src/NuGetGallery/Strings.resx b/src/NuGetGallery/Strings.resx
@@ -1254,7 +1254,4 @@ The {1} Team</value>
   <data name="ForgotPassword_Disabled_Error" xml:space="preserve">
     <value>Forgot password is disabled.</value>
   </data>
-  <data name="FrameworkFilterInformation_Tooltip" xml:space="preserve">
-    <value>Filters packages based on the target frameworks included in the NuGet Package.</value>
-  </data>
 </root>
diff --git a/src/NuGetGallery/ViewModels/PackageListViewModel.cs b/src/NuGetGallery/ViewModels/PackageListViewModel.cs
@@ -84,6 +84,6 @@ public PackageListViewModel(
 
         public Dictionary<string, FrameworkFilterHelper.FrameworkFilterGroup> FrameworkFilters = FrameworkFilterHelper.FrameworkFilters;
 
-        public string TargetFrameworkInformationLink = "https://learn.microsoft.com/en-us/dotnet/standard/frameworks";
+        public string FrameworksFilteringInformationLink = "https://learn.microsoft.com/nuget/consume-packages/finding-and-choosing-packages#advanced-filtering-and-sorting";
     }
 }
diff --git a/src/NuGetGallery/Views/Shared/ListPackages.cshtml b/src/NuGetGallery/Views/Shared/ListPackages.cshtml
@@ -82,10 +82,8 @@
                                 <fieldset id="frameworkfilters">
                                     <legend>
                                         Frameworks
-                                        <a href="@(Model.TargetFrameworkInformationLink)" title="Frameworks filter information">
-                                            <i class="framework-filter-info-icon ms-Icon ms-Icon--Info" tabindex="0"
-                                               data-content="@Strings.FrameworkFilterInformation_Tooltip"
-                                               alt="@Strings.FrameworkFilterInformation_Tooltip"></i>
+                                        <a href="@(Model.FrameworksFilteringInformationLink)" title="Filters packages based on the target frameworks included in the NuGet Package. Click here to learn more.">
+                                            <i class="framework-filter-info-icon ms-Icon ms-Icon--Info"></i>
                                         </a>
                                     </legend>
                                     @foreach (var framework in Model.FrameworkFilters.Values)