Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict tolerance for unit/integration tests #662

Open
sjsprecious opened this issue Sep 19, 2024 · 0 comments · May be fixed by #670
Open

More strict tolerance for unit/integration tests #662

sjsprecious opened this issue Sep 19, 2024 · 0 comments · May be fixed by #670
Assignees
Labels
bug Something isn't working

Comments

@sjsprecious
Copy link
Collaborator

sjsprecious commented Sep 19, 2024

One index bug in LuDecomposition is identified by @K20shores in #625 .

After the index bug is fixed, the tolerance used in the unit and integration tests is expected to be much small in magnitude.

Acceptance Criteria

  • All tolerances are set to a value as low as possible for any test which in some way uses LU decomposition

Ideas

  • Try lowering tolerances in these files
    • All the integration tests: test/integration
    • test/unit/solver/test_linear_solver_policy.hpp
      • Which is called from test/unit/solver/test_linear_solver.cpp and test/unit/jit/solver/test_jit_linear_solver.cpp and test/unit/cuda/solver/test_cuda_linear_solver.cpp
    • test/unit/solver/test_lu_decomposition_policy.hpp
      • Which is called from test/unit/solver/test_lu_decomposition.cpp and test/unit/jit/solver/test_jit_lu_decomposition.cpp and test/unit/cuda/solver/test_cuda_lu_decomposition.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants