Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor follow-ons from PR #1245 #1273

Open
kutschke opened this issue May 24, 2024 · 2 comments
Open

Minor follow-ons from PR #1245 #1273

kutschke opened this issue May 24, 2024 · 2 comments
Assignees

Comments

@kutschke
Copy link
Collaborator

kutschke commented May 24, 2024

PR #1245 introduced a new data member to StrawDigiMC. We need to update

https://github.com/Mu2e/Offline/blob/main/Print/src/StrawDigiMCPrinter.cc
https://github.com/Mu2e/Offline/blob/main/Validation/src/ValStrawDigiMC.cc

The first creates user friendly printout. The second histograms everything in the payload and is used in nightly validation:
https://mu2e.fnal.gov/atwork/computing/ops/val/valJob/nightly/nightly.html . The policy for the printer is that lowest level printout is restricted to one line per entry and is curated. Speak with Ray to learn if he has guidelines for the other verbosity levels. This is where the EnumToString will make live easy: operator << prints both numerical value and the string.

@kutschke kutschke changed the title Minor follow-ons from PR Minor follow-ons from PR #1245 May 24, 2024
@edcallaghan
Copy link
Contributor

@kutschke I will link #1272 here, though I am not sure to what extent that overlaps with what you had planned for this.

@kutschke
Copy link
Collaborator Author

@kutschke I will link #1272 here, though I am not sure to what extent that overlaps with what you had planned for this.

I screwed up with the newline = create new issue feature. It's updated now. This is not a high priority but it's straightforward. It's orthogonal to the big questions you ask in 1272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants