-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13-1, 14] Change definition of scaling factor alpha
, add center and approximations for Hermite functions, add Fourier transform utility functions
#15
Merged
Commits on Jul 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4e8f44d - Browse repository at this point
Copy the full SHA 4e8f44dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f84d93 - Browse repository at this point
Copy the full SHA 9f84d93View commit details -
- fixed loading of test files that do not contain test but dependencies that cannot be loaded ?
Configuration menu - View commit details
-
Copy full SHA for 5e201f0 - Browse repository at this point
Copy the full SHA 5e201f0View commit details -
- escaped imports of unaccessible dependencies for test-file generation in GitHub CI tests by making the `if __name__ == "__main__"` include these imports and function definitions
Configuration menu - View commit details
-
Copy full SHA for 408d818 - Browse repository at this point
Copy the full SHA 408d818View commit details -
- test whether Cython build can be removed from GitHub actions for testing ?
Configuration menu - View commit details
-
Copy full SHA for d8f158d - Browse repository at this point
Copy the full SHA d8f158dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2132928 - Browse repository at this point
Copy the full SHA 2132928View commit details -
- moved the full package back into an `src`-folder BLD: - updated `pyproject.toml` and `setup.py` to account for the movement to the `src`-folder - removed dedicated Cython build from CI test pipeline
Configuration menu - View commit details
-
Copy full SHA for 08849e4 - Browse repository at this point
Copy the full SHA 08849e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9d285 - Browse repository at this point
Copy the full SHA ff9d285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f07f43 - Browse repository at this point
Copy the full SHA 3f07f43View commit details
Commits on Jul 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ca0611 - Browse repository at this point
Copy the full SHA 4ca0611View commit details -
- fixed CI pipeline wrong folder include ? BLD: - added isort check
Configuration menu - View commit details
-
Copy full SHA for 5da4991 - Browse repository at this point
Copy the full SHA 5da4991View commit details -
Configuration menu - View commit details
-
Copy full SHA for e813f7c - Browse repository at this point
Copy the full SHA e813f7cView commit details -
- fixed missing `isort` dependency in CI? - fixed wrong import sort order in Cython Hermite functions
Configuration menu - View commit details
-
Copy full SHA for af55627 - Browse repository at this point
Copy the full SHA af55627View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb691c - Browse repository at this point
Copy the full SHA 8cb691cView commit details -
- type-ignored Cython import that was not properly resolved by `pyright` ?
Configuration menu - View commit details
-
Copy full SHA for c1e1737 - Browse repository at this point
Copy the full SHA c1e1737View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54cdf10 - Browse repository at this point
Copy the full SHA 54cdf10View commit details -
- again trying to resolve the wrong import error of Cython module by `pyright` in CI ?
Configuration menu - View commit details
-
Copy full SHA for 912259d - Browse repository at this point
Copy the full SHA 912259dView commit details -
- fixed wrong `pyright` Cython import error of Cython import in CI
Configuration menu - View commit details
-
Copy full SHA for 973bde4 - Browse repository at this point
Copy the full SHA 973bde4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd4fe7f - Browse repository at this point
Copy the full SHA fd4fe7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b49758 - Browse repository at this point
Copy the full SHA 0b49758View commit details -
[10 develop] Add coverage to CI pipeline (#11)
* DOC: - added Python versions and `black` code style to `README` * DOC: - added `isort` badge to `README` * TST: - added `--no-jit`-flag to `pytest` to enable proper coverage of Numba functions * tmp: - first test of CI with coverage report ? * BUG: - fixed failure of `pytest-xdist` and `pytest-cov` in GitHub CI (works locally) ? * BUG: - fixed accidentally placed `\` for `./tests` in coverage CI action ? * BUG: - added codecov to CI pipeline ? * TST: - tried to readd `pytest-xdist` for coverage reports ? * wip: - reset example Jupyter notebook number 3 * MAINT: - made `_get_num_workers` a function of the `_utils`-model TST: - increased coverage to 100% by testing `np.float32` x-values for the Hermite functions was well as super negative numbers of requested workers * DOC: - added setup, installation, and development instructions to `README` * DOC: - switched back from `README.rst` to `README.md` BLD: - made CI pipeline push actions apply to the main branch only
Configuration menu - View commit details
-
Copy full SHA for 9383090 - Browse repository at this point
Copy the full SHA 9383090View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dc5225 - Browse repository at this point
Copy the full SHA 0dc5225View commit details -
Configuration menu - View commit details
-
Copy full SHA for 457479d - Browse repository at this point
Copy the full SHA 457479dView commit details -
- added `mypy` to CI pipeline BUG: - fixed type error that `mypy` uncovered for the `filename_parameters_mapping` for the Hermite function reference generation
Configuration menu - View commit details
-
Copy full SHA for 5bd6eae - Browse repository at this point
Copy the full SHA 5bd6eaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b91333 - Browse repository at this point
Copy the full SHA 5b91333View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35dafc5 - Browse repository at this point
Copy the full SHA 35dafc5View commit details -
- added `pycodestyle` as a part of the CI checks BUG: - fixed a line too long error revealed by `pycodestyle`
Configuration menu - View commit details
-
Copy full SHA for 913fb68 - Browse repository at this point
Copy the full SHA 913fb68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43940a2 - Browse repository at this point
Copy the full SHA 43940a2View commit details
Commits on Jul 22, 2024
-
- added functions that help for computing discrete/continuous Fourier transforms (`fourier_transform._fft_utils`) TST: - implemented a test suite for `fourier_transform._fft_utils`
Configuration menu - View commit details
-
Copy full SHA for 9573890 - Browse repository at this point
Copy the full SHA 9573890View commit details
Commits on Jul 23, 2024
-
DOC: - updated equations with new definitions of $\alpha$ - updated `README` with new equations and added respective reference that these definitions are based on
Configuration menu - View commit details
-
Copy full SHA for 285178a - Browse repository at this point
Copy the full SHA 285178aView commit details -
MAINT: - removed redundant Numba version of the legacy Hermite functions and `jit`-compiled the NumPy-version instead - fixed minor documentation issues
Configuration menu - View commit details
-
Copy full SHA for c02276a - Browse repository at this point
Copy the full SHA c02276aView commit details -
MAINT: - adapted interface to Hermite functions to the new definition of $\alpha$ in terms of both implementation and docs
Configuration menu - View commit details
-
Copy full SHA for 91b675d - Browse repository at this point
Copy the full SHA 91b675dView commit details -
DOC: - updated example scripts and resulting plots with new definition of $\alpha$
Configuration menu - View commit details
-
Copy full SHA for dba7fe9 - Browse repository at this point
Copy the full SHA dba7fe9View commit details -
TST: - generated new references files for testing the new definition of $\alpha$ for the Hermite functions - adapted Hermite function tests to properly run for the new definition of $\alpha$ - configured Hermite function tests via global constants and kept comments in them more vague - made test for Cramér's inequality of the Hermite functions ensure that the boundary value is not only an upper bound but actually reached - changed `requirements` for GitHub CI because with a re-arrangement of the `if __name__ == "__main__"` in the Hermite function reference generation file, `sympy` and `tqdm` became CI requirements as well
Configuration menu - View commit details
-
Copy full SHA for f6f6957 - Browse repository at this point
Copy the full SHA f6f6957View commit details -
- fixed failing `ruff` for too long line in docstring of new `_fft_utils` BLD: - temporarily enabled CI on push to current branch to check if it still passes after an adaption in `pyright`
Configuration menu - View commit details
-
Copy full SHA for 5f1f410 - Browse repository at this point
Copy the full SHA 5f1f410View commit details -
BLD: - disabled GitHub CI on push to the current branch again after verifying that it still runs
Configuration menu - View commit details
-
Copy full SHA for e691e44 - Browse repository at this point
Copy the full SHA e691e44View commit details
Commits on Jul 24, 2024
-
ENH: - added `x_center` to the Hermite function basis for shifting the Hermite functions in x-direction - added input validation for `x_center` MAINT: - renamed `hermite_functions._interface` to `hermite_functions._func_interface` to prepare for the class interface - made type handling of Hermite function input validation smarter and safer by first converting to the target type and then testing only for this one - made argument types for `x` of the Hermite functions broader by also including lists and tuples TST: - made input validation tests for Hermite functions be executed before the Hermite function reference tests - made input validation tests for Hermite functions not only check failure but also success cases - added tests for the new `x_center` and ensured that it does not modify the original `x`-values for the Hermite functions (after this causes some problems) DOC: - updated all equations and the `README` to clarify the new `x_center` for the Hermite functions - updated installation commands (also mentioned venv activation) and test/check commands in `README`
Configuration menu - View commit details
-
Copy full SHA for f68ee32 - Browse repository at this point
Copy the full SHA f68ee32View commit details -
- added y-axis to Hermite-function-scale-effect-plot - fixed first vertical x-axis for order `n=0` not showing in the plot at all
Configuration menu - View commit details
-
Copy full SHA for ca34d08 - Browse repository at this point
Copy the full SHA ca34d08View commit details
Commits on Jul 26, 2024
-
MAINT: - moved Hermite function input validation to dedicated file ENH: - pushed forgotten files that add `x_center` to Hermite functions TST: - pushed forgotten files that test the new `x_center` of the Hermite functions and improved the testing of the Hermite function input validation
Configuration menu - View commit details
-
Copy full SHA for 4aff78f - Browse repository at this point
Copy the full SHA 4aff78fView commit details -
- split up tests for Hermite functions into dedicated test files to be more flexible
Configuration menu - View commit details
-
Copy full SHA for 3d30cbc - Browse repository at this point
Copy the full SHA 3d30cbcView commit details -
DOC: - added common matplotlib style to unify all plots - updated example scripts with new matplotlib style - added shifted center to Hermite function example 01
Configuration menu - View commit details
-
Copy full SHA for 8386963 - Browse repository at this point
Copy the full SHA 8386963View commit details -
- made example plots 01 and 02 for Hermite functions more visually appealing/less overwhelming
Configuration menu - View commit details
-
Copy full SHA for 9a3ed2c - Browse repository at this point
Copy the full SHA 9a3ed2cView commit details -
ENH: - added auxiliary script that auto-generates a Python file with spline coefficients for almost exactly evaluating the largest zero (= outermost roots) of the Hermite functions up to order ~100_000
Configuration menu - View commit details
-
Copy full SHA for 7833b04 - Browse repository at this point
Copy the full SHA 7833b04View commit details
Commits on Jul 28, 2024
-
MAINT: - refactored the reference creation for the largest roots of the Hermite functions to not minimize the relative but the absolute error - relaxed permitted absolute error in reference creation for the largest roots of the Hermite functions because the SciPy-reference is not that accurate DOC: - mentioned that the SciPy-reference for the largest roots of the Hermite functions is not perfectly accurate
Configuration menu - View commit details
-
Copy full SHA for 4508b00 - Browse repository at this point
Copy the full SHA 4508b00View commit details -
ENH: - added script to create reference data for the largest extrema of the Hermite functions - added new `_approximations`-module for Hermite functions that offers approximations for their largest roots, largest extrema, and fadeout points TST: - added tests for the new `_approximations`-module DOC: - added legend to first plot in script that creates reference data for the largest roots of the Hermite functions
Configuration menu - View commit details
-
Copy full SHA for 8d29b2d - Browse repository at this point
Copy the full SHA 8d29b2dView commit details
Commits on Jul 30, 2024
-
- refactored the reference data generation for the largest roots and extrema of the Hermite functions to fit the splines based on relative errors - updated reference data and plots created by these scripts - made this reference data generation a developer-only script TST: - made test for largest root of Hermite functions more meaningful by adapting the tolerance for checking to the actual magnitude of the root position - made test for largest extremum of Hermite functions more meaningful by checking the y-values (and not the x-values) of the extremum against a numerical optimisation (also with magnitude-adaptive tolerances)
Configuration menu - View commit details
-
Copy full SHA for 9f73b75 - Browse repository at this point
Copy the full SHA 9f73b75View commit details -
- made all plot saves in examples available for developers only - aligned plots in terms of visuals (especially titles and sizes) - updated `README` with new plots and developer-only environment variable
Configuration menu - View commit details
-
Copy full SHA for 73197cf - Browse repository at this point
Copy the full SHA 73197cfView commit details -
- added additional scripts checks to GitHub CI - made all tools cause actual failures rather than just printing test output ? - broke CI on purpose, by badly formatting `auxiliary_scripts\02_hermite_functions_largest_extremum.py` and `src\robust_hermite_ft\hermite_functions\_c_hermite.pyx`
Configuration menu - View commit details
-
Copy full SHA for 4557b06 - Browse repository at this point
Copy the full SHA 4557b06View commit details -
- CI tests fixed `black` formatting after confirming that it works - `isort` is the next to check
Configuration menu - View commit details
-
Copy full SHA for 0013c14 - Browse repository at this point
Copy the full SHA 0013c14View commit details -
- fixed `isort` CI failure after confirming that it works - `pyright` is the next to check
Configuration menu - View commit details
-
Copy full SHA for 5d06d33 - Browse repository at this point
Copy the full SHA 5d06d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4f13a6 - Browse repository at this point
Copy the full SHA a4f13a6View commit details -
- fixed `isort` problem again - checking for reasons why `pyright`-check fails by running it separately without output ?
Configuration menu - View commit details
-
Copy full SHA for 4a7896d - Browse repository at this point
Copy the full SHA 4a7896dView commit details -
- fixed `pyright` error handling in CI - `mypy` is the next one to check, but for now it's checked whether it just runs through even though there is an error
Configuration menu - View commit details
-
Copy full SHA for 5401719 - Browse repository at this point
Copy the full SHA 5401719View commit details -
- pushing updated CI workflow file for properly testing that `mypy` just runs through - added `matplotlib` to CI requirements to avoid `pyright` from throwing an error ?
Configuration menu - View commit details
-
Copy full SHA for e6ae861 - Browse repository at this point
Copy the full SHA e6ae861View commit details -
- going back to the start for tests after `mypy` also stopped CI correctly - starting with `black` test
Configuration menu - View commit details
-
Copy full SHA for 7d48768 - Browse repository at this point
Copy the full SHA 7d48768View commit details -
- `black` successfully stopped the CI without customised handling - `isort` is the next to check without customised handling
Configuration menu - View commit details
-
Copy full SHA for ffffcd1 - Browse repository at this point
Copy the full SHA ffffcd1View commit details -
- also `isort` stops the CI on failure - next to check is `pyright`
Configuration menu - View commit details
-
Copy full SHA for e60a349 - Browse repository at this point
Copy the full SHA e60a349View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0ac7b5 - Browse repository at this point
Copy the full SHA f0ac7b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58f1f4b - Browse repository at this point
Copy the full SHA 58f1f4bView commit details -
- Hermite functions now support all kinds of real numeric scalars/Arrays as `x`-values, integer scalars as `n`-values, and real numeric scalars for `alpha` and `x_center` after making the input validation way more relaxed and smarter TST: - test for Hermite function input validation now covers Python and Numpy scalars individually and on top of that also includes Pandas series and Python Arrays - test for data link to original `x` in Hermite functions now evaluates dynamically whether memory is shared by checking if changes in the copy/view are reflected in the original - added a completely new test set whether the Hermite functions yield the same results for all different kinds of `x`-values, `n`-values, `alpha`- and `x-center` values
Configuration menu - View commit details
-
Copy full SHA for 5829925 - Browse repository at this point
Copy the full SHA 5829925View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ac95fa - Browse repository at this point
Copy the full SHA 0ac95faView commit details -
- fixed type incompatibility that caused `mypy` to crash the GitHub CI
Configuration menu - View commit details
-
Copy full SHA for 34e48ce - Browse repository at this point
Copy the full SHA 34e48ceView commit details -
- fixed missing coverage for default and error handling of FFT utility functions
Configuration menu - View commit details
-
Copy full SHA for df6ac6b - Browse repository at this point
Copy the full SHA df6ac6bView commit details -
- arranged legend of plot for special points of Hermite functions in a better position
Configuration menu - View commit details
-
Copy full SHA for 7c6f2b8 - Browse repository at this point
Copy the full SHA 7c6f2b8View commit details -
- removed unnecessary list parametrization for orthonormality test of Hermite functions
Configuration menu - View commit details
-
Copy full SHA for cf318e3 - Browse repository at this point
Copy the full SHA cf318e3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.