Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check errors found when testing against CellML 1.0 test set #49

Open
MichaelClerx opened this issue Apr 26, 2019 · 2 comments
Open

Check errors found when testing against CellML 1.0 test set #49

MichaelClerx opened this issue Apr 26, 2019 · 2 comments

Comments

@MichaelClerx
Copy link
Contributor

I've started testing cellmlmanip against my CellML 1.0 test set, and have updated it to generate reports of what went right/wrong

https://github.com/MichaelClerx/cellml-validation/blob/master/reports

At the moment, I've only run the valid files through cellmlmanip. There are some errors that I expect (unit components aren't supported), but others I'm not so sure about.

Would it be a good idea for @tamuri to have a look at the failed tests and maybe create an issue for each one or create a single issue with a check-list? Just so we've seen each fail and have either fixed a bug or made (and documented) a decision? Some of the passes might also require work, for example I'd like it if we raised an error or warning if reactions were spotted

(None of this should prevent us from merging #25 by the way, just future stuff!)

@MichaelClerx
Copy link
Contributor Author

By the way, I haven't figured out what the best way to license these tests is, but I want it to be so that everyone can copy-paste them freely, even the whole set, without hassle. So feel free to base new tests on these!

@MichaelClerx
Copy link
Contributor Author

For almost every fail, we should certainly have better error messages :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant