Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wizard connection for complex passwords (stored as html entities) #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

enursed
Copy link
Contributor

@enursed enursed commented May 31, 2020

since we read the pogodroid password from xml file, we need to convert some chars like <, >, .. back to ascii.
to do this i found a nice solution from WinEunuuchs2Unix: on https://stackoverflow.com/a/43058947)

tested with simple and complex passwords like N(%;%F,}+>w

Thx i hope this is useful for you guys doing a great job! :)

@krzee
Copy link
Collaborator

krzee commented Jul 29, 2020

i started merging this in, and realized that if i support it here i need to support it in 42mad... im not prepared to do that, i kinda feel like some chars just shouldnt be used 🤷
if you care to also add it to 42mad and test that too, then i'll accept it... but i totally dont mind if you dont want to

@Expl0dingBanana
Copy link
Contributor

I can update the 64 bit branch to auto-encode XML characters

@krzee
Copy link
Collaborator

krzee commented Jul 29, 2020

i havent wrapped my ahead around if my side will work with that, but if you do that sounds cool too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants