We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST_F(NegativeGpuAVRayTracing, BasicTraceRaysDeferredBuild) { TEST_DESCRIPTION( "Setup a ray tracing pipeline (ray generation, miss and closest hit shaders, and deferred build) and acceleration " "structure, and trace one " "ray. Only call traceRay in the ray generation shader"); SetTargetApiVersion(VK_API_VERSION_1_2); AddRequiredFeature(vkt::Feature::rayTracingPipeline); AddRequiredFeature(vkt::Feature::accelerationStructure); AddRequiredFeature(vkt::Feature::bufferDeviceAddress); VkValidationFeaturesEXT validation_features = GetGpuAvValidationFeatures(); RETURN_IF_SKIP(InitFrameworkForRayTracingTest(&validation_features)); RETURN_IF_SKIP(InitState()); vkt::rt::Pipeline pipeline(*this, m_device); // Set shaders const char* ray_gen = R"glsl( #version 460 #extension GL_EXT_ray_tracing : require // Requires SPIR-V 1.5 (Vulkan 1.2) #extension GL_EXT_buffer_reference : enable layout(buffer_reference, std430) readonly buffer RayTracingParams { vec4 nothing; float Tmin; float Tmax; }; layout(binding = 0, set = 0) uniform accelerationStructureEXT tlas; layout(binding = 1, set = 0) uniform uniform_buffer { RayTracingParams rt_params; }; layout(location = 0) rayPayloadEXT vec3 hit; void main() { traceRayEXT(tlas, gl_RayFlagsOpaqueEXT, 0xff, 0, 0, 0, vec3(0,0,1), rt_params.Tmin, vec3(0,0,1), rt_params.Tmax, 0); } )glsl"; pipeline.SetGlslRayGenShader(ray_gen); const char* miss = R"glsl( #version 460 #extension GL_EXT_ray_tracing : require layout(location = 0) rayPayloadInEXT vec3 hit; void main() { hit = vec3(0.1, 0.2, 0.3); } )glsl"; pipeline.AddGlslMissShader(miss); const char* closest_hit = R"glsl( #version 460 #extension GL_EXT_ray_tracing : require layout(location = 0) rayPayloadInEXT vec3 hit; hitAttributeEXT vec2 baryCoord; void main() { const vec3 barycentricCoords = vec3(1.0f - baryCoord.x - baryCoord.y, baryCoord.x, baryCoord.y); hit = barycentricCoords; } )glsl"; pipeline.AddGlslClosestHitShader(closest_hit); pipeline.AddBinding(VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, 0); pipeline.AddBinding(VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, 1); pipeline.CreateDescriptorSet(); // Create TLAS vkt::as::BuildGeometryInfoKHR tlas(vkt::as::blueprint::BuildOnDeviceTopLevel(*m_device, *m_default_queue, *m_commandBuffer)); pipeline.GetDescriptorSet().WriteDescriptorAccelStruct(0, 1, &tlas.GetDstAS()->handle()); // Create uniform_buffer vkt::Buffer rt_params_buffer(*m_device, 4 * sizeof(float), 0, vkt::device_address);// missing space for Tmin and Tmax vkt::Buffer uniform_buffer(*m_device, 16, VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT); auto data = static_cast<VkDeviceAddress *>(uniform_buffer.memory().map()); data[0] = rt_params_buffer.address(); uniform_buffer.memory().unmap(); pipeline.GetDescriptorSet().WriteDescriptorBufferInfo(1, uniform_buffer.handle(), 0, 16, VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER); pipeline.GetDescriptorSet().UpdateDescriptorSets(); // Add one to use the descriptor slot GPU-AV tried to reserve const uint32_t max_bound_desc_sets = m_device->phy().limits_.maxBoundDescriptorSets + 1; // First try to use too many sets in the pipeline layout { m_errorMonitor->SetDesiredWarning( "This Pipeline Layout has too many descriptor sets that will not allow GPU shader instrumentation to be setup for " "pipelines created with it"); std::vector<const vkt::DescriptorSetLayout *> desc_set_layouts(max_bound_desc_sets); for (uint32_t i = 0; i < max_bound_desc_sets; i++) { desc_set_layouts[i] = &pipeline.GetDescriptorSet().layout_; } vkt::PipelineLayout bad_pipe_layout(*m_device, desc_set_layouts); m_errorMonitor->VerifyFound(); } // Then use the maximum allowed number of sets std::vector<const vkt::DescriptorSetLayout *> des_set_layouts(max_bound_desc_sets - 1); for (uint32_t i = 0; i < max_bound_desc_sets - 1; i++) { des_set_layouts[i] = &pipeline.GetDescriptorSet().layout_; } VkPipelineLayoutCreateInfo pipe_layout_ci = vku::InitStructHelper(); pipeline.GetPipelineLayout().init(*m_device, pipe_layout_ci, des_set_layouts); // Deferred pipeline build RETURN_IF_SKIP(pipeline.DeferBuild()); RETURN_IF_SKIP(pipeline.Build()); // Bind descriptor set, pipeline, and trace rays m_commandBuffer->begin(); vk::CmdBindDescriptorSets(*m_commandBuffer, VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR, pipeline.GetPipelineLayout(), 0, 1, &pipeline.GetDescriptorSet().set_, 0, nullptr); vk::CmdBindPipeline(*m_commandBuffer, VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR, pipeline.Handle()); vkt::rt::TraceRaysSbt trace_rays_sbt = pipeline.GetTraceRaysSbt(); vk::CmdTraceRaysKHR(*m_commandBuffer, &trace_rays_sbt.ray_gen_sbt, &trace_rays_sbt.miss_sbt, &trace_rays_sbt.hit_sbt, &trace_rays_sbt.callable_sbt, 1, 1, 1); m_commandBuffer->end(); m_default_queue->Submit(*m_commandBuffer); m_device->Wait(); }
Self Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08737 ] | MessageID = 0xa5625282 | vkCreateShaderModule(): pCreateInfo->pCode (spirv-val produced an error): Pointer storage class must be PhysicalStorageBuffer: ConvertPtrToU %49 = OpConvertPtrToU %ulong %17
When replacing the uniform buffer with a storage buffer, buffer device address accesses are not instrumented
The text was updated successfully, but these errors were encountered:
spencer-lunarg
No branches or pull requests
When replacing the uniform buffer with a storage buffer, buffer device address accesses are not instrumented
The text was updated successfully, but these errors were encountered: