Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RewardsError overloaded #6

Open
bedeho opened this issue Nov 25, 2019 · 0 comments
Open

RewardsError overloaded #6

bedeho opened this issue Nov 25, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bedeho
Copy link
Member

bedeho commented Nov 25, 2019

RewardsError is error for set_reward_relationship and add_reward_relationship, however they do not constitue identical error sets, e.g. only the latter has case matchin RewardsError::RewardSourceNotFound. This conflicts with Joystream/joystream#36 (comment). Separate error types.
@bedeho bedeho added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bedeho