Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microservice for Profiler #116

Closed
Ismoh opened this issue May 12, 2023 · 1 comment
Closed

Microservice for Profiler #116

Ismoh opened this issue May 12, 2023 · 1 comment
Assignees
@Ismoh
Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop. good_first_issue Good for newcomers help_wanted Extra attention is needed
Milestone
Features or QoL

Comments

@Ismoh
Copy link
Owner

Ismoh commented May 12, 2023

While testing de-/serialisation, it came to my mind to exclude profiler from NoitaMP.
As there are plenty of fast and reliable network events, it wouldn't be difficult to add two new events for profiling start and stop.

Start schema:
id (known as cpc), functionName, frame, startTime
Stop schema:
id (cpc), functionName, frame, stopTime

Profiler service will be started as a separated process by NoitaMP. Simple profiler.bat on windows, which will do the profiling and calculations.
If there is no start or stop entry, put duration to -1.
Exclude from networkCache and resent algorithmn in NoitaMP.
@Ismoh Ismoh added the enhancement New feature or request. This will increase MINOR version number, when merged into develop. label May 12, 2023
@Ismoh Ismoh added this to the Features or QoL milestone May 12, 2023
@Ismoh Ismoh self-assigned this May 12, 2023
@Ismoh Ismoh added help_wanted Extra attention is needed good_first_issue Good for newcomers labels May 12, 2023
@Ismoh
Copy link
Owner Author

Ismoh commented Oct 1, 2023

Started with this in #67 and improving in #133

@Ismoh Ismoh closed this as completed Oct 1, 2023
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ismoh Ismoh

Labels
enhancement New feature or request. This will increase MINOR version number, when merged into develop. good_first_issue Good for newcomers help_wanted Extra attention is needed
Projects
NoitaMP
Status: ✅ Done
Milestone
Features or QoL
Development

No branches or pull requests
1 participant
@Ismoh