Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 1.19 assets fails #135

Open
FireController1847 opened this issue Jul 27, 2022 · 0 comments
Open

Using 1.19 assets fails #135

FireController1847 opened this issue Jul 27, 2022 · 0 comments

Comments

@FireController1847
Copy link

FireController1847 commented Jul 27, 2022

Describe the bug
When using 1.19 assets (see below), it attempts to request the following URL, which does not exist:

https://assets.mcasset.cloud/1.19/assets/minecraft/models/minecraft:block/cube_all.json

However, if we rename "minecraft:block" to just "block," it works fine:

https://assets.mcasset.cloud/1.19/assets/minecraft/models/block/cube_all.json

To Reproduce
Steps to reproduce the behavior:

  1. Use the "assetRoot" option
  2. Set your asset root to the following: https://assets.mcasset.cloud/1.19
  3. Attempt to render a "netherite_block"

Expected behavior
No error

Screenshots
N/A

Additional context
I downloaded the embed/model index.html file and manually inserted the assetRoot to the options. This is the URL I used:

index.html?models=block/netherite_block&shadow=false&camera.position=26,26,26&controls=false&controls.rotate=false&controls.zoom=false&controls.pan=false

This issue begins to appear starting at Minecraft 1.16. Minecraft 1.15 works fine.

Tracing further into the code, it appears that post Minecraft 1.15 assets includes the namespace in the asset name which seems to screw up the URLs. I'm implementing a temporary fix on my fork to simply remove these namespaces, but it's definitely jank and wouldn't recommend this as a permanent solution lol

FireController1847 added a commit to FireController1847/MineRender that referenced this issue Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant