Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

only create sid cookie at login if sid not already in cookies #3464

Closed
wants to merge 1 commit into from

Conversation

pascalmartin
Copy link

We Backport this fix IdentityServer/IdentityServer4#441 in IdentityServer3

Can we confirm is the right fix.

We have 2 application in same domain

www.domain.com => App1
www.domain.com/subapp => App2

Using the oidc-client.js with IdentityServer3, this setup not working when we activate monitorSession when second app is authenticate the other App refresh in loop.

@dnfclas
Copy link

dnfclas commented Jan 17, 2017

Hi @pascalmartin, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Jan 17, 2017

@pascalmartin, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@pascalmartin
Copy link
Author

@brockallen Do I need to create a issue for this PR?

@brockallen
Copy link
Member

I've just not had a chance to look at it yet.

@brockallen
Copy link
Member

Also, we don't take PRs on master -- can you resubmit against dev?

@pascalmartin
Copy link
Author

Y resubmit on dev in this PR #3484

@brockallen
Copy link
Member

thanks, i'll have a look when i can

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session id being overwritten while user logged in
3 participants