Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and add more translations #27

Open
humdingerb opened this issue Nov 21, 2017 · 33 comments
Open

Update and add more translations #27

humdingerb opened this issue Nov 21, 2017 · 33 comments
Labels
hacktoberfest Issues proposed to Hacktoberfest participants help wanted
Milestone

Comments

@humdingerb
Copy link
Member

humdingerb commented Nov 21, 2017

If anyone wants to update translations with missing strings or add strings for more languages, please visit Polyglot. You can log in with your GitHub account.
Thanks!

@janus2
Copy link
Member

janus2 commented Nov 30, 2017

I took you literally... 3rd bullet point done! I understand now that it.catkeys was an example, too late.

@ghost
Copy link

ghost commented Jan 4, 2018

This is the Romanian version.

@janus2
Copy link
Member

janus2 commented Jan 4, 2018

Thanks included with PR #38

@Lan72
Copy link

Lan72 commented Jan 9, 2018

The Ukrainian translation was ready more than a month ago. A new version of Weather was released, and the translation into it was never added. I wonder why?

@Lan72
Copy link

Lan72 commented Jan 9, 2018

uk_weather.zip

@janus2
Copy link
Member

janus2 commented Jan 9, 2018

I added your contribution with PR #50. I'm very sorry we missed your translation. The simple answer to your question is we are dumb... and for we I mean me.

@scottmc
Copy link
Member

scottmc commented Jan 9, 2018

I suspect translations can also be submitted as pull requests?

@janus2
Copy link
Member

janus2 commented Jan 9, 2018

Yes, but in the forum there is this explanation:

When you're done, send your translated catkeys file to the app's developer, or paste it via the form at sprunge.us3, which keeps the important whitespace (space, tab) contrary to e.g. pastebin.com, and link to it from a comment.
If you feel up to it, try to work directly with the catkeys of the project's repo and submit a pull-request as described in the post Contributing via pull requests1.

I think Lan72 is right to be disappointed.

@humdingerb
Copy link
Member Author

WTF, we're not allowed to make mistakes once in a while?!

@humdingerb humdingerb changed the title Add more translations Update and add more translations Feb 9, 2018
@RajatGarg97
Copy link

Hi all,
I am interested in contributing to Haiku.
Can I add French translation strings to the weather application?
Also please tell me if there is a specific path, the developers at Haiku follow to make contributions.
Thanks and Regards

@pulkomandy
Copy link
Member

pulkomandy commented Mar 11, 2018 via email

@Briseur
Copy link

Briseur commented Mar 29, 2018

French translation completed on Polyglot.
I used french Yahoo weather to match most of time their translations. That's how I discovered that they changed and now use Foggy instead of Fog.

@victordomingos
Copy link

I would like to work on the translation to Portuguese (pt_PT).

@Knezzen
Copy link

Knezzen commented Dec 22, 2018

When will Weather be updated and released to include the new translations? The Swedish translation was uploaded 10 months or so, but Weather has yet to be rebuilt to include it through HaikuDepot. When can a rebuild be initiated and by who?

@humdingerb
Copy link
Member Author

Additional translation are seldomly cause for a new release. But since the last GCI and Janus' recent work did result in some substantial improvements, I'm sure we'll have a new version soon.

Whoever tags a new release should make sure the latest catkeys are imported from Polyglot first. And before that: upload the latest catkeys to Polyglot if there were changes to strings (besides some being removed).

@KapiX
Copy link
Member

KapiX commented Dec 25, 2018

I disagree. I think doing a new bugfix release (x.y.z in semver) only with new translations is perfectly acceptable; after all it fixes a deficiency in the program, and is not really a new feature. Waiting for fixes in the program to come and treating translations as just a "passenger" is not a way to go, since those main fixes may never come.

It appears that's not the case for Weather, but for other apps it might be. Even then, for Weather the translation was finished a long time ago and it was never released.

@scottmc scottmc added this to the 1.2 milestone Jul 7, 2022
@scottmc scottmc added the hacktoberfest Issues proposed to Hacktoberfest participants label Sep 27, 2022
@nexus6-haiku
Copy link
Member

@humdingerb what's the status of the translations? Are all completed translations in Polyglot (100%) included now?

@nexus6-haiku
Copy link
Member

@scottmc does it make sense to bind the translations to a specific milestone, especially a major? Provided we adopt SemVer, I see them more suitable for rolling patches.

@scottmc
Copy link
Member

scottmc commented Oct 11, 2022

Not bind, just set 1.2 as a goal. Perhaps we can aim for an early November date for the next release, that way any work done during this hacktoberfest sprint can be included.

@humdingerb
Copy link
Member Author

@humdingerb what's the status of the translations? Are all completed translations in Polyglot (100%) included now?

I've just added ca, es, it and an updated fr with ed1045c .

@scottmc
Copy link
Member

scottmc commented Nov 15, 2022

Maybe time to pull in the latest translations and then do a 1.1.0 (or is it 1.2.0) release? @humdingerb @nexus6-haiku

@nexus6-haiku
Copy link
Member

We need to clean things up a little bit and now it’s time!
Currently the source code reads 1.1, so we should move to 1.2 and update code, resources, GitHub release and eventually the recipe to be aligned.
The milestones on GitHub already reflect this versioning, IIRC.
Is there a way to automatically trigger a new build on HaikuPorts when a new release is created here?

@humdingerb
Copy link
Member Author

Is there a way to automatically trigger a new build on HaikuPorts when a new release is created here?

I don't think so. Recipes only get built if the $portVersion changes (for Weather going from v1.1 to v1.2) or when the REVISION constant in the recipe is increased.

I'll put a quick shoutout to finish translations in the forums.

Alternatively, we could wait for Haiku beta4 to hit, which should be soon, and ask @nexus6-haiku if he wanted to try making the icons scale with the font size, as several recent Haiku hidpi changes have done already. I haven't looked much into it, but the relevant Haiku commits were quite small... :)

@nexus6-haiku
Copy link
Member

nexus6-haiku commented Nov 16, 2022

I don’t know how much it could take to adapt the UI but I’ll look at it.
I don’t think the timeframe would fit with Beta4, though. I would draw a line here, bump to 1.2 with the current code base and add as many translations as possible.
Then I would like to fix the Deskbar replicant and the UI scaling in 1.3.
How does that sound?

@humdingerb
Copy link
Member Author

Sounds good. I created #97 as reminder.

@humdingerb
Copy link
Member Author

After waiting a week for translations to finish, it looks like we should create the new release with what we have, including Esperanto and Spanish which are both at 96%. OK?

(In the future, it would be best to create a new issue "Do a release v1.3" or something if you think it's time again. Had to wreak my mind to find this ticket again... :) )

@nexus6-haiku
Copy link
Member

nexus6-haiku commented Nov 20, 2022 via email

@nexus6-haiku
Copy link
Member

nexus6-haiku commented Nov 20, 2022 via email

@nexus6-haiku
Copy link
Member

nexus6-haiku commented Nov 20, 2022 via email

@humdingerb
Copy link
Member Author

There is an ongoing debate about translating the app name. I think that unless the name is translated everywhere including the Depot, it shouldn’t be translated at all.

The app name is translatable. It's up to the translators if they translate it or not. Same as at HaikuDepot. It seems few people are interested in translating SUMMARY/DESCRIPTION (and package title) at HaikuDepotServer. I do it for German, at least for "end-user packages", not for libraries etc.

For the records there is a little bug in the location selection window where “City:” is never translated.

FWIW, it's working fine for German...

@nexus6-haiku
Copy link
Member

Thanks! I’ll check both the “City” translation and HaikuDepot.

@humdingerb
Copy link
Member Author

Be advised, you'll need certain permissions at HDS to translate, upload screenshots/icons etc.

@dospuntos
Copy link

Norwegian translation added to Polyglot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues proposed to Hacktoberfest participants help wanted
Development

No branches or pull requests