Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and add more translations #92

Open
humdingerb opened this issue Aug 1, 2017 · 43 comments
Open

Update and add more translations #92

humdingerb opened this issue Aug 1, 2017 · 43 comments

Comments

@humdingerb
Copy link
Member

humdingerb commented Aug 1, 2017

If anyone wants to update translations with missing strings or add strings for more languages, please visit Polyglot. You can log in with your GitHub account.
Thanks!

@Lan72
Copy link

Lan72 commented Aug 2, 2017

The Ukrainian uk.catkeys is ready: http://sprunge.us/TDIQ

@Giova84
Copy link

Giova84 commented Aug 3, 2017

I made an italian catkeys file, and Filer looks fine. However when I go in filer's rules tab, the tooltips aren't translated: the buttons to add and remove rules, still show "Add rule" and "Remove rule"; the other parts of Filer looks properly translated.

See: http://funkyimg.com/i/2w1Cr.png

The strange thing is that in the catkey file, the line
Add rule RuleEditWindow Aggiungi regola is present but no showed inside Filer.
And in the catkey file I can't see the line about "Remove rule."

Humdinger, If you want I can send you the file however.

@Giova84
Copy link

Giova84 commented Aug 3, 2017

Sorry: I am on Qupzilla and I cant edit my previous comment.

I have seen that also all others catkey files (en, de, and the Ukrainian from Lan72) shows the same issue:
the Remove rule line is not present; the Add rule line is present but not applied.

@Giova84
Copy link

Giova84 commented Aug 3, 2017

Also the buttons to add or remove actions in the rule window, arent translated, despite the fact that
Add AutoFilerTab Used as button in a file panel Aggiungi is present in the catkey file.

@humdingerb
Copy link
Member Author

Apparently, there were a few strings that slipped through our localization efforts...

@Giova84, please get the updated en.catkeys once more. You can load them in CatKeysEditor and go to "Tools | Import..." to import your already translated it.catkeys. Check "Hide translated" to quickly see the new strings.

@Lan72, since your translation was already merged, please get the uk.catkeys and translate the new strings.

Sorry about that, guys...

@Giova84
Copy link

Giova84 commented Aug 3, 2017

Inside CateKeys editor I just see the checkbox "Hide translated", but I don't see at all the "Tools | Import..." option... Am I blind? :-)

@humdingerb
Copy link
Member Author

Ahhrrrrgglll... looks like the CatKeysEditor in HaikuDepot is behind what's at https://github.com/puckipedia/BeLocalized...

Easiest if you give me your current it.catkeys. I add the new strings, push them to ths repo and you download them again to translate the rest.

@humdingerb
Copy link
Member Author

FYI, I just updated CatKeysEditor in HaikuDepot (for gcc2h).

@Lan72
Copy link

Lan72 commented Aug 3, 2017

Updated uk.catkeys http://sprunge.us/YITh

@Giova84
Copy link

Giova84 commented Aug 3, 2017

@humdingerb No problem: I compiled the new CatKeysEditor and I made the new it.catkeys :-)
Is available here (zipped to keep the attributes): http://softwaredepot.altervista.org/upload/it.catkeys.zip

@Giova84
Copy link

Giova84 commented Aug 3, 2017

Please wait: I want to improve it again the translations :-)

@humdingerb
Copy link
Member Author

@Lan72 : Thanks! But your sprunge is still missing "Add" and "Remove". Take this one instead: http://sprunge.us/VFgV

@Giova84 : Thanks!

@Giova84
Copy link

Giova84 commented Aug 3, 2017

@Giova84
Copy link

Giova84 commented Aug 3, 2017

About "Run AutoFiler on system startup" I choosed "Esegui Filer all'avvio del sistema" (Run AutoFiler on system startup) because IMHO is more indicative for the app; if you don't agree, feel free to change it as "Esegui AutoFiler all'avvio del sistema" :-)

@Lan72
Copy link

Lan72 commented Aug 3, 2017

Finally updated uk.catkeys: http://sprunge.us/aYZI

@humdingerb
Copy link
Member Author

Thanks guys!

@Giova84, I know what you mean, but I tend toward keeping it "AutoFiler". The distinction between Filer and AutoFiler (which is a background watchdog just calling Filer when a file enters its territory) is explained in the documentation. And it's the title of the tab. And when users look for it with ProcessController etc. they also find "AutoFiler".
All in all, it's more consistend and correct.

@Giova84
Copy link

Giova84 commented Aug 3, 2017

Ok, you have been clear and you're right. Since is just a word ("Filer" to "AutoFiler") can you take care of change it? I would avoid to insert too much links, to avoid confusion :-)

@Giova84
Copy link

Giova84 commented Aug 3, 2017

However, I'd like to point out the "about section":

Filer is an automatic file organizer. It takes the files it's opened with or that are dropped on it and moves, renames, copies or does all sorts of other things with them according to rules created by the user. HelpTab Filer is an automatic file organizer. It takes the files it's opened with or that are dropped on it and moves, renames, copies or does all sorts of other things with them according to rules created by the user.

Is a good explanation, but it doesn't talk about AutoFiler; the users which doesn't know this app, so, will be unaware of AutoFiler; would be a good idea to add something like?

"AutoFiler take care of automate the rules on background" or something similar?

@Giova84
Copy link

Giova84 commented Aug 3, 2017

I'm very sorry for the noise, but I tend to be a perfectionist :-)
I updated again the catkey: I fixed the Filer to Autofiler and improved something else.
Sorry!

EDIT:

I logged in on Chrome on Windows because here I can edit my comments (On Qupzilla on Haiku i was unable to edit my comments - and on WebPositive I was also unable to login at all on GitHub!) - Furthermore, on Haiku, I faced errors with my internet connection: started to be slow and unreliable :-[

So I'm very sorry, but is about technical difficulties.

So: the right catkey is the number 4, because the last which I uploaded on Haiku, to me result corrupted...
http://softwaredepot.altervista.org/upload/it.catkeys_4.zip

@humdingerb please let me know if is ok.

@humdingerb
Copy link
Member Author

Don't worry @Giova84 , we can continue changing catkeys until the release. After that it's always awkward to publish a new version just for a changed string... :)

Is a good explanation, but it doesn't talk about AutoFiler; the users which doesn't know this app, so, will be unaware of AutoFiler; would be a good idea to add something like?

Besides the other translators becoming fed up with me, I think the About text on the Help tab is quite long already. I'd even consider making it shorter...
After all, the description in HaikuDepot is quite detailed and with the "User documentation" button so visible, people can easily look things up, when they are unsure about the AutoFiler tab.

I hope you don't get the impression I always shoot down your suggestions... )

One more thing. You have this translation:

Filer dropzone DropZoneTab Trascina qui i file

This only appears when right clicking the Replicant handle of the DropZone replicant. Try it. Seeing that you don't translate "Dropzone" or "Filer" anywhere else, is this really what you intended?
BTW, no need to zip stuff up, it's all just plain text.

@Giova84
Copy link

Giova84 commented Aug 3, 2017

@humdingerb , first of all don't you worry: I didn't get the impression that you shoot down my suggestions: I just ask since you are more expert and so I am glad to accept your considerations :-)

About Filer dropzone DropZoneTab Trascina qui i file I didn't translated Dropzone elsewhere just because Trascina qui i file was too long for the GUI; however, for consistency I agree with you: we can change Trascina qui i file to Dropzone: i think that is clearer, since in the Dropzone tab there is the explanation - translated - of what Dropzone does.

However: currently I'm still on Windows because here on Google Chrome I can properly use GitHub's website (offtopic: we have the need to build, on Haiku gcc2h, the new Qupzilla and the new QTWebkit - the ones from @threedeyes - with the hope that the new Qupzilla will work better with GitHub: on GitHub of HaikuPorts I see that yesterday the recipes has been fixed for gcc2h)
So, ATM I can't fix the catkey: feel free to fix it, thank you 👍 :-)

@humdingerb
Copy link
Member Author

@Giova84, I'll update the it.catkeys to "Filer Dropzone", so the user also sees to what app the replicant belongs to.

Web+ does work for me for github, only uploading fails...
I agree, a new QupZilla and Qt sounds like a good idea. As soon as 3deyes gives the signal, it'll be built. Hopefully even by 3deyes himself, as Qt is a massive, massive package... :)

@Giova84
Copy link

Giova84 commented Aug 4, 2017

Ok, I've seen that you added the it.catkeys :-)

However I have a doubt: in the catkey file I've seen that there are two entries that I wasn't be able to see in Filer: "Is before" and "Is after", and I translated them by attempting to follow the logic, but since I don't see them in Filer, I don't know to what "is before" and "is after" are referring. Can you give me some hints?

@humdingerb
Copy link
Member Author

"Is before" and "Is after" isn't used yet, but it may be in the future. In fact, I wonder why there isn't a "When" attribute for Email files...

@owenca
Copy link
Contributor

owenca commented Aug 4, 2017

"is before" and "is after" are for file date comparisons, which have never been implemented. I have commented out the related code and can submit a PR if that's preferred.

@humdingerb
Copy link
Member Author

Nah. We already have those translation, those are short string that don't take lots of effort. And maybe we'll need it in the future.

@owenca
Copy link
Contributor

owenca commented Aug 5, 2017

Now that the catkeys will change for the new ConflictWindow, I'd like to take out "is before" and "is after" along with all the "date" code. It would make Filer run a teeny bit faster. :)

@humdingerb
Copy link
Member Author

OK by me then.

@phoudoin
Copy link

phoudoin commented Aug 7, 2017

French translation
fr.catkeys.zip

@humdingerb
Copy link
Member Author

I just updated all the catkeys. With the improved ConflictWindow, there are a couple of added strings now. I'd appreciate if our translaters could take another quick look. Just get the catkeys for your language, open in CatKeysEditor and check "Hide translated" and you see what's new.
Thanks!

@phoudoin
Copy link

phoudoin commented Aug 10, 2017

Updated French translation
fr.catkeys.zip

@Lan72
Copy link

Lan72 commented Aug 10, 2017

Updated Ukrainian translation: http://sprunge.us/BaQI

@Giova84
Copy link

Giova84 commented Aug 10, 2017

Also Italian has been updated: http://sprunge.us/ZgOh

@humdingerb
Copy link
Member Author

Thanks everyone!
How much would you hate me, if I tell you that I just noticed that the default rules and their paths aren't yet translated? And that after I said on IRC that the GUI strings are definitely done yesterday...

Anyway, I have updated the catkeys once more. If you don't find the time to translate, those strings will just stay English, so no difference to the status quo. :)

Sorry again, we originally planned to release over a week ago, but then decided that Owen would implement the additional functionality of the Conflict window (showing modified dates and size of source/target file, opening them etc.). Well worth it, I think.

@phoudoin
Copy link

There is also the "When" + "Do" which become "If" & "Then" to (re)translate, guys.

@phoudoin
Copy link

Updated
fr.catkeys.zip
French translation

@Giova84
Copy link

Giova84 commented Aug 16, 2017

Italian catkeys file updated: http://sprunge.us/fZjY

@humdingerb
Copy link
Member Author

@owenca: I'd say Filer is now in a very nice state, we should release. What's your opinion on incomplete translations; inlcude anyway or not?
I'd say only release 100% translations. Having an all-English Filer GUI in an otherwise localized Haiku strikes me as better than a incomplete localized Filer that has sprinkled English strings in the GUI.

That would remove nl and uk fromt the release.

@owenca
Copy link
Contributor

owenca commented Aug 24, 2017

Sure, but after merging another PR (#115) I have just pushed. :)

Also, I posted a follow-up question in Issue #112.

@Lan72
Copy link

Lan72 commented Sep 8, 2017

humdingerb

I'd say only release 100% translations.
That would remove nl and uk fromt the release.

Um... You should have done it in vain. Ukrainian translation is complete. I left untranslated only special terms that are either not translated, or their conversion is inexpedient. For example: Filer, AutoFiler or DropZone. As far as I've noticed, these terms are not translated in other languages included in the release.

@humdingerb
Copy link
Member Author

CatKeysEditor shows these missing translations:
uk.catkeys
The paths and rule names at least, should be translated. If you could provide those, we can add the uk.catkeys to the next release.

@Lan72
Copy link

Lan72 commented Sep 9, 2017

Full Ukrainian translation: http://sprunge.us/SLIc

@humdingerb
Copy link
Member Author

Thanks! I've commited your uk.catkeys.

@humdingerb humdingerb changed the title Add more translations Update and add more translations Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants