Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pydantic models to their respective module #336

Open
korikuzma opened this issue Jul 31, 2024 · 0 comments
Open

Move pydantic models to their respective module #336

korikuzma opened this issue Jul 31, 2024 · 0 comments
Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@korikuzma
Copy link
Member

Could also consider taking the pydantic models that are associated with specific modules (eg db connection args w/ the uta handler) and putting them directly into that module. The pattern of a distinct schemas.py module or group of modules is more suited to MVC-like web apps imho (where you have a models module, a views module, and a controller module), and while there are some models that are truly general-purpose and can't be placed anywhere else, others can probably be moved closer to where they're used.

Originally posted by @jsstevenson in #334 (comment)

@korikuzma korikuzma added priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

No branches or pull requests

1 participant