Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle jop failing to sync #407

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Handle jop failing to sync #407

merged 1 commit into from
Mar 28, 2024

Conversation

isra17
Copy link
Member

@isra17 isra17 commented Mar 28, 2024

isra17
isra17 commented Mar 28, 2024
View reviewed changes
src/saturn_engine/worker_manager/services/sync.py
@@ -28,52 +29,62 @@ def _sync_jobs(
static_definitions: StaticDefinitions,
session: AnySyncSession,
) -> None:
logger = logging.getLogger(__name__)

# Jobs with no interval
for saturn_job in static_definitions.jobs.values():
Copy link
Member Author

@isra17 isra17 Mar 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a big indent with try/except, it's annoying that github diff doesn't see this...

@isra17 isra17 merged commit 7744e21 into main Mar 28, 2024
2 of 3 checks passed
@isra17 isra17 deleted the isra/hande-sync-error branch March 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isra17