Merged queue timeout and result timeout #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me.... WDYT @isra17 ? |
|
Technically there is a short race condition and |
|
Technically there should be a delta between the two, but I'm not sure by how much realistic scenarios, would 10 or 20 be enough? |
look like the poll delay is 0.5 seconds, so setting the expiration of the job to |
isra17
approved these changes
Mar 26, 2024
Pourliver
force-pushed
the
maxc/unify_timeouts
branch
from
a1d648e
to
c6201d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent ARQ changes, it is now possible to raise
TimeoutErrorfrom diverging values of queues and results timeouts. This aims to give us saner defaults