Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr] add pull_request_template.md #406

Closed
krHERO opened this issue Aug 15, 2024 · 1 comment
Closed

[ftr] add pull_request_template.md #406

krHERO opened this issue Aug 15, 2024 · 1 comment

Comments

@krHERO
Copy link
Member

krHERO commented Aug 15, 2024

Is your feature request related to a problem? Please describe.
Despite github recommendations for community standards the edirom-online repo does not have a pull_request_template.md yet.
It seems useful to have a standard process for every PR, to have an overview/list for the author to check before requesting a review and to capture some standard information to make the review-process easier.

Describe the solution you'd like
Examine several examples of pull requests and choose one to adapt (with some adjustments).

@krHERO krHERO added this to the 1.0.0 milestone Aug 15, 2024
@krHERO krHERO self-assigned this Aug 15, 2024
krHERO added a commit to krHERO/Edirom-Online that referenced this issue Aug 15, 2024
this commit introduces a PR template.

Refs Edirom#406
@krHERO
Copy link
Member Author

krHERO commented Sep 5, 2024

this issue is closed with PR #407

@krHERO krHERO closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant