-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal call now fails #42
Comments
Uhh, this one is worrying since it turned out it doesn't fail until it's plotted to a device. Precisely, saving above to a variable doesn't raise an exception, displaying it does:
and our tests don't do the latter. This time, we won't be releasing fixed version immediately, mainly because of CRAN having winter break and not exactly liking our constant resubmissions. Also, I want to have a deeper look at the code before releasing, since it's like a fifth bug you submitted and that's enough embarrassment for me. |
I hear you. I try to space mine to not hit more than six resubmission in seven months (which means saying no to Conrad on some Armadillo updates). Most of my other repos move slower these days. That said, having the ability to have "local" (non-CRAN) releases is good. I eat my own dog food here as I have a few drat created repos (one overall for anything, one more for just Rcpp things). These days you also have Jeroen's r-universe, and of course the ability to build from git -- but I remain firmly in the 'mark a release, create a tarball, provide the release tarball' camp than on binaries or tarballs from each commit as he does which I still think is a little too close to the fire. That said, the problem your teams is tackling is hard as there are so many different dependency schemes and outcomes and plot combinations. Plus you are too nice too me and have too many plot options :) Anyway, if you have a fix to test I'd be happy to |
It's basically two-line fix and I pushed it to fix/no-deps branch, if you'd need it. And it's true about too many plot options, the way they interact with each other almost makes a mess of the code logic. By the way, thanks for sharing your knowledge about |
Thanks, worked like a charm. [ I am still partial to incrementing version numbers. I'd call this 0.4.1.1 (maybe once merged to mainline); I have no scheme for branches. ] |
(right, |
(Not a big fan of |
Release 0.4.1 is really sweet but I fear this is a regression:
With the default of
strong
we can get zero rowdata.frame
objects, and the plotting function does not like those.The text was updated successfully, but these errors were encountered: