Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make responding service calls generic #36

Merged
merged 3 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/build.extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export function BuildTypes({ logger, hass, type_build, config, internal }: TServ
` AppleNotificationData,`,
` NotificationData,`,
` PICK_ENTITY,`,
` WeatherGetForecasts,`,
`} from "./helpers";`,
``,
PICK_FROM_PLATFORM,
Expand Down
43 changes: 38 additions & 5 deletions src/i-call-service.extension.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { DOWN, is, TServiceParams, UP } from "@digital-alchemy/core";
import { HassServiceDTO, ServiceListField, ServiceListServiceTarget } from "@digital-alchemy/hass";
import { factory, SyntaxKind, TypeElement } from "typescript";
import { factory, SyntaxKind, TypeElement, TypeNode, TypeParameterDeclaration } from "typescript";

export async function ICallServiceExtension({ hass, type_build }: TServiceParams) {
return async function () {
Expand Down Expand Up @@ -49,16 +49,49 @@ export async function ICallServiceExtension({ hass, type_build }: TServiceParams
// > [service_name]: (service_data) => Promise<void | unknown>
// > }
// > }
const isReturnResponse = is.boolean(value.response?.optional);
const genericIdent = "T";

// Override default return type for some known cases
let defaultReturnType: TypeNode = factory.createKeywordTypeNode(SyntaxKind.UnknownKeyword);
if (domain === "weather" && key === "get_forecasts") {
defaultReturnType = factory.createTypeReferenceNode(
factory.createIdentifier("WeatherGetForecasts"),
undefined,
);
}

// Set up for the default case of (service_data) => Promise<void>
let generic: TypeParameterDeclaration[] | undefined = undefined;
let returnType: TypeNode | undefined = factory.createTypeReferenceNode(
factory.createIdentifier("Promise"),
[factory.createKeywordTypeNode(SyntaxKind.VoidKeyword)],
);

// If the service might return a response, change instead to <T = unknown>(service_data) => Promise<T>
if (isReturnResponse) {
generic = [
factory.createTypeParameterDeclaration(
undefined,
factory.createIdentifier(genericIdent),
undefined,
defaultReturnType,
),
];
returnType = factory.createExpressionWithTypeArguments(
factory.createIdentifier("Promise"),
[factory.createTypeReferenceNode(factory.createIdentifier(genericIdent), undefined)],
);
}

return type_build.tsdoc.serviceComment(
factory.createMethodSignature(
undefined,
factory.createIdentifier(key),
undefined,
undefined,
generic,
serviceParameters(domain, key, value),
factory.createTypeReferenceNode(factory.createIdentifier("Promise"), [
factory.createKeywordTypeNode(SyntaxKind.VoidKeyword),
]),
returnType,
),
key,
value,
Expand Down
Loading