Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make responding service calls generic #36

Merged
merged 3 commits into from
Sep 10, 2024
Merged

feat: make responding service calls generic #36

merged 3 commits into from
Sep 10, 2024

Conversation

allout58
Copy link
Contributor

@allout58 allout58 commented Sep 9, 2024 •
edited
Loading

📬 Changes

Makes responding service calls generic, with option to override in known cases like weather.get_forecasts

Goes along with Digital-Alchemy-TS/hass#65

Fixes #10

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed) - Tested Manually

@zoe-codez
Copy link
Member

@allout58 allout58 changed the title feat: make all service calls generic feat: make responding service calls generic, with option to override in known cases like weather Sep 10, 2024
@allout58 allout58 changed the title feat: make responding service calls generic, with option to override in known cases like weather feat: make responding service calls generic Sep 10, 2024
@zoe-codez zoe-codez merged commit e771067 into Digital-Alchemy-TS:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoe-codez zoe-codez zoe-codez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate response optional flag
2 participants
@allout58 @zoe-codez