Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove dependency on pkg_resources in favour of importlib" #183

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

ndevenish
Copy link
Contributor

#181

This ran into the python 3.12 importlib compatibility issue.

This reverts commit 28dc035.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (0f0f9e8) to head (bc17882).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          24       24           
  Lines        2424     2424           
  Branches      440      440           
=======================================
  Hits         2021     2021           
  Misses        284      284           
  Partials      119      119           

@ndevenish ndevenish merged commit b20f7da into main Sep 13, 2024
23 of 24 checks passed
@ndevenish ndevenish deleted the revert-181-180_remove_pkg_resources branch September 13, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant