Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transmission change in rotation to after detector unstaged #504

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #500

To test:

  • Confirm new test works
  • Confirm all points in the issue were fixed or new issues raised

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (1928954) to head (b1b162a).
Report is 3851 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #504       +/-   ##
===========================================
+ Coverage   57.08%   77.59%   +20.51%     
===========================================
  Files          28       89       +61     
  Lines        3199     6700     +3501     
===========================================
+ Hits         1826     5199     +3373     
- Misses       1373     1501      +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram merged commit ef4a92c into main Sep 20, 2024
17 of 18 checks passed
@DominicOram DominicOram deleted the 500_hotfixes_from_testing branch September 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperion testing 17/09
2 participants