Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRC: Ensure easy way to change box sizes and exposure time #231

Open
DominicOram opened this issue Jun 21, 2024 · 3 comments
Open

XRC: Ensure easy way to change box sizes and exposure time #231

DominicOram opened this issue Jun 21, 2024 · 3 comments
Labels

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Jun 21, 2024

It may be useful to oversample the XRC and take data with smaller box sizes (even though the aperture is bigger than this). This should give us a more precise location for the centre of mass.

Acceptance Criteria

  • There is an easy way for the user to change box size and exposure time
  • We communicate how to do this to the user
  • This does snot affect aperture selection
  • We confirm on the beamline that we still go to the correct place even with smaller box sizes
@dperl-dls
Copy link
Contributor

  • easy means: change it in only one place, and documented, and where relevant people have permission
  • we have never changed it before, needs testing
  • either we can:
    • supply this with the xray centring,
    • or point neil to CONST.PARAM.GRIDSCAN.BOX_WIDTH_UM,
    • or put that in config service and point neil there

will go with option 2, and make new issues for option 3 (including validating numerical input)

we think small to medium

@DominicOram
Copy link
Contributor Author

Wants testing with beam

@DominicOram
Copy link
Contributor Author

Tested in #211. Failed to work easily. Box size isn't just changed by changing BOX_WIDTH_UM because it isn't passed through to grid_detection_plan. Trying to hard code in that call resulted in https://ispyb.diamond.ac.uk/dc/visit/cm37235-3/dcg/12681792 , which failed to kickoff the FGS. Some offline time needed to investigate

@DominicOram DominicOram changed the title XRC: Ensure easy way to change box sizes XRC: Ensure easy way to change box sizes and exposure time Aug 19, 2024
@DominicOram DominicOram transferred this issue from DiamondLightSource/hyperion Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo This Sprint
Development

No branches or pull requests

2 participants