This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
add unstage for zocalo #1084
Merged
add unstage for zocalo #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 62 62
Lines 2919 2921 +2
=======================================
+ Hits 2725 2727 +2
Misses 194 194 ☔ View full report in Codecov by Sentry. |
DominicOram
suggested changes
Jan 18, 2024
Comment on lines
241
to
243
| yield from bps.stage( | ||
| fgs_composite.zocalo | ||
| ) # connect to zocalo and make sure the queue is clear |
There was a problem hiding this comment.
Should: I'm a bit worried that we're not explicitly waiting on the queue being cleared. If we run this without specifying wait I think the behaviour looks to be that it will just not wait so we end up assuming the 2s queue clear is less than the first zocalo message we actually want. Probably a reasonable assumption but I would prefer if we put this in a group that we do wait on at some point, not sure when we would though?
2 tasks
DominicOram
approved these changes
Jan 22, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/dodal_298 add unstage for zocalo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for DiamondLightSource/dodal#300
To test: