This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
(DiamondLightSource/dodal#271) Move beamline_parameters.py and associ… #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated unit tests into dodal
* Fix test failure due to zocalo results not being present
rtuck99
force-pushed
the
dodal_271_move_beamline_parameters_into_dodal
branch
from
97f87e2
to
b50e90f
Compare
rtuck99
force-pushed
the
dodal_271_move_beamline_parameters_into_dodal
branch
from
b50e90f
to
a408bd1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
==========================================
- Coverage 93.89% 93.83% -0.07%
==========================================
Files 59 58 -1
Lines 2786 2726 -60
==========================================
- Hits 2616 2558 -58
+ Misses 170 168 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See (DiamondLightSource/dodal#271)
Link to dodal PR (if required): DiamondLightSource/dodal#272
To test:
nb I haven't fixed the issue with the ispyb imports here but hopefully it still passes in CI)I have now pushed some commits to fix this plus another test failure relating to zocalo results not being mocked