This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Remove using import-mode=importlib for tests and add required __init__ files #1056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
import-mode=importlib
option hides a number of legitimate errors for me and for CI (though interestingly not for @rtuck99). In particular it hides the badIspybIds
import that this fixes. I'm not sure why we added this option in in the first place @dperl-dls as it seems to work w/o it?To test: