This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Fix issues in robot load found in testing #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
- Coverage 93.75% 93.72% -0.03%
==========================================
Files 58 58
Lines 2801 2807 +6
==========================================
+ Hits 2626 2631 +5
- Misses 175 176 +1 ☔ View full report in Codecov by Sentry. |
dperl-dls
approved these changes
Dec 18, 2023
| @@ -185,7 +185,7 @@ def put(self, plan_name: str, action: Actions): | |||
| ) | |||
| if plan is None: | |||
| raise PlanNotFound( | |||
| f"Experiment plan '{plan_name}' has no 'run' method." | |||
| f"Experiment plan '{plan_name}' not found in context. Context has {self.context.plan_functions.keys()}" | |||
Managed to fix it by just removing the |
|
Test is transient, see #999. So I will merge this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049
To test:
In another terminal run an xray centre then robot load plan:
curl -X PUT http://127.0.0.1:5005/wait_for_robot_load_then_centre/start --data-binary "@tests/test_data/parameter_json_files/good_test_wait_for_robot_load_params.json" -H "Content-Type: application/json". Confirm this gives a success