Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Deposit robot load info into ISPyB #1045

Closed
wants to merge 6 commits into from
Closed

Conversation

DominicOram
Copy link
Collaborator

@DominicOram DominicOram commented Dec 14, 2023

Fixes #1017

Requires #1040 and #1038 - merge these first

To test:

  1. Do thing x
  2. Confirm thing y happens

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f40b2ea) 93.69% compared to head (1366679) 93.71%.
Report is 68 commits behind head on main.

❗ Current head 1366679 differs from pull request most recent head 8d186f3. Consider uploading reports for the commit 8d186f3 to get more accurate results

Files Patch % Lines
...interaction/ispyb/store_datacollection_in_ispyb.py 63.63% 4 Missing ⚠️
...hyperion/external_interaction/ispyb/ispyb_utils.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
+ Coverage   93.69%   93.71%   +0.02%     
==========================================
  Files          58       59       +1     
  Lines        2774     2801      +27     
==========================================
+ Hits         2599     2625      +26     
- Misses        175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram
Copy link
Collaborator Author

Closed in favour of #1055 to rebase

@DominicOram DominicOram deleted the 1017_robot_load_in_ispyb branch December 19, 2023 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISPYB: Deposit robot load entry
1 participant