Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fixed some type errors #1044

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fixed some type errors #1044

merged 1 commit into from
Dec 14, 2023

Conversation

DominicOram
Copy link
Collaborator

To test:

  1. Run pyright . on main and here
  2. Confirm number of failures reduced
  3. Confirm no behaviour change

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (734d5f7) 93.70% compared to head (cbd336c) 93.52%.

Files Patch % Lines
src/hyperion/snapshot_plan.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
- Coverage   93.70%   93.52%   -0.18%     
==========================================
  Files          58       58              
  Lines        2780     2780              
==========================================
- Hits         2605     2600       -5     
- Misses        175      180       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@dperl-dls dperl-dls merged commit 2e0d58d into main Dec 14, 2023
15 of 24 checks passed
@dperl-dls dperl-dls deleted the fix_type_errors branch December 14, 2023 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants