Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourites Fragment #4

Open
tanmaydixit opened this issue Jul 25, 2018 · 2 comments
Open

Favourites Fragment #4

tanmaydixit opened this issue Jul 25, 2018 · 2 comments
Labels
feature New feature to be added wontfix This will not be worked on

Comments

@tanmaydixit
Copy link
Member

The item on the herald list will have a favorite(heart) button, this will become red if someone clicks it.
Then the list item(herald) article will come on the favorites fragment. Only the ones marked heart by the user will be shown out here(the List on the Favourites fragment).
The data that the user has chosen this as fav or not will be stored locally.

@tanmaydixit tanmaydixit added approved This issue has been approved by maintainers. Grab them before others. feature New feature to be added labels Jul 25, 2018
@aryanagarwal15
Copy link

@tanmaydixit I don't think we need a favourite's tab made for DoJMA App. I have not seen any person using this on DoJMA's android app. Lets just keep 4 tabs in the bottom nav bar in iOS.

@Rushi98
Copy link
Member

Rushi98 commented Sep 19, 2018

I use favorites!

@jainvandit99 jainvandit99 reopened this Sep 26, 2018
@jainvandit99 jainvandit99 added wontfix This will not be worked on and removed approved This issue has been approved by maintainers. Grab them before others. labels Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature to be added wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants