-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
materials.csv and enchantments.csv are incorrect #29
Comments
Material data numbers were removed in 1.13. The two column tables for material slugs and names is correct. ItemNames line 54
line 69 The item names then all parse properly, and getItemName() returns the proper name as expected. |
Also there is a space after every single name which is unhelpful |
Could also be resolved by updating the materials.csv file to have 2 commas. For example, instead of:
You have:
That makes the values in the code remain the same, as there are still 3 data points in values, and values[2] is still correct. You guys are doing great work. Thank you for all of your efforts! |
Apparently the code expects the files like this one: https://github.com/CivClassic/CivModCore/blob/master/src/main/resources/enchantments.csv
but those weren't included in recent merges.
The text was updated successfully, but these errors were encountered: