Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materials.csv and enchantments.csv are incorrect #29

Open
ProgrammerDan opened this issue Nov 12, 2019 · 3 comments
Open

materials.csv and enchantments.csv are incorrect #29

ProgrammerDan opened this issue Nov 12, 2019 · 3 comments

Comments

@ProgrammerDan
Copy link

Apparently the code expects the files like this one: https://github.com/CivClassic/CivModCore/blob/master/src/main/resources/enchantments.csv

but those weren't included in recent merges.

@ukulelelesheep
Copy link

ukulelelesheep commented Nov 14, 2019

Material data numbers were removed in 1.13. The two column tables for material slugs and names is correct.

ItemNames line 54

if (values.length < 3) { //<-- Change from 3 to 2
	logger.warning("This material row does not have enough data: " + line);
	// Go to the next line
	line = reader.readLine();
	continue;
}

line 69
String name = values[2]; //<--Change values from 2 to 1

The item names then all parse properly, and getItemName() returns the proper name as expected.

@ukulelelesheep
Copy link

Also there is a space after every single name which is unhelpful

@zhovan8
Copy link

zhovan8 commented Nov 18, 2019

Could also be resolved by updating the materials.csv file to have 2 commas.

For example, instead of:

  • ACACIA_BOAT,Acacia Boat

You have:

  • ACACIA_BOAT,,Acacia Boat

That makes the values in the code remain the same, as there are still 3 data points in values, and values[2] is still correct.
I have attached an updated version of the csv, which also removed the spaces at the end of the lines (and so at the end of the names).
I had to append the file extension with .txt because github would not allow me to attach a .csv file.

You guys are doing great work. Thank you for all of your efforts!

materials.csv.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants