-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification for English pattern with number followed by lower letter #1902
Comments
I don't think that these are valid cases as they have stated that That being said, the only one that is valid with this is |
@
Braille input/output should not include spaces, no? |
It shouldn't. I just placed it so it's easier to read. |
It is confusing what to translate from an English pattern consisting of number followed by lower letter, such as
1a
.Based on the README
1a
is supposed to be translated to ⠼⠁⠀⠁, which is[number follows][1][space][a]
. However, if we translate it ([number follows][1][space][a]
) back to English, should it be1a
or1 a
?Based on test cases
In
translator.test.py
,Abc 123 xYz
was translated to.....OO.....O.O...OO...........O.OOOO.....O.O...OO..........OO..OO.....OOO.OOOO..OOO
. Note that there is only 1space
symbol between3
andx
. This implies that for pattern like1 a
(note the space in the middle) should translate to[number follows][1][space][a]
, which conflicts with the aforementioned translation for1a
To avoid confusion, please clarify how the translations should be for the cases below.
1a
1 a
1Ab
1A2
What are the corresponding Braille for the English above?
The text was updated successfully, but these errors were encountered: