-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a fallback if no ADPC is available #24
Comments
Hi, you raise a valid point regarding 'fallback' in case ADPC is not implemented. And you're correct that in such scenarios a 'classic' banner would be used. That being said, IMHO the case where 'ADPC is unavailable' is the same as today's existing situation. So while it seems like a 'solution', it isn't one since it comes with all the issues and tricks that ADPC was created to resolve. I suggest generalising this issue by instead asking/stating:
|
Fantastic, thank you for sharing this work @jucktnich! I will try have a closer look; we were thinking of creating something like this. Perhaps it could even work as a polyfill, i.e. modifying the DOM such that the website can use the ADPC Javascript API as if the browser supported it. This is roughly what our browser extension does too. The main differences would be how it is displayed (of course the page cannot access to browser UI, but that seems acceptable), and how to store the responses between visits; I see you set a cookie (line 266) named |
Problem and Motivation
For an website project I chose to use ADPC, but since its not supported by most browsers and few people use the Add-on you still need a classic banner. This is extra work needed.
So I thought it was cool if there was a JS module which took care of it all and the developer only needed to import the module and make requests like with native ADPC, so I developed the banner for my site and made a module from it.
Benefits
Many devs (hopefully) would opt for this module and therefor if ADPC becomes more widespread, many sites will support it.
My implementation: jucktnich/adpc-compatibility-mode
The text was updated successfully, but these errors were encountered: