Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename overwritten payload counter in ReadoutModel #92

Open
ShyamB97 opened this issue Feb 15, 2023 · 0 comments
Open

Rename overwritten payload counter in ReadoutModel #92

ShyamB97 opened this issue Feb 15, 2023 · 0 comments

Comments

@ShyamB97
Copy link
Contributor

Variable m_num_payloads_overwritten and the corresponding log message below is misleading because contents of the buffer is not overwritten. So it should be named something like m_num_payloads_overflowed.

if (!m_latency_buffer_impl->write(std::move(payload))) {
TLOG_DEBUG(TLVL_TAKE_NOTE) << "***ERROR: Latency buffer is full and data was overwritten!";
m_num_payloads_overwritten++;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant