Using BinarySearchQueueModel with HSI data sometimes results in data not being found

[strilov]

When using BinarySearchQueueModel with HSI data, there is a pathology where the data is not found successfully if the occupancy of the queue is 1. The debug output of such a case is pasted below.

Data request for trig/seq_num=1.0 with
Trigger TS=104034153929408170
Oldest stored TS=104034153929408170
Newest stored TS=104034153929408170
Start of window TS=104034153929407170
End of window TS=104034153929409170 Latency buffer occupancy=1
2022-Sep-30 15:01:03,862 LOG [dunedaq::readoutlibs::DefaultRequestHandlerModel<ReadoutType, LatencyBufferType>::RequestResult dunedaq::readoutlibs::DefaultRequestHandlerModel<ReadoutType, LatencyBufferType>::data_request(dunedaq::dfmessages::DataRequest, bool) [with ReadoutType = dunedaq::hsilibs::TIMING_HSI_FRAME_STRUCT; LatencyBufferType = dunedaq::readoutlibs::BinarySearchQueueModel<dunedaq::hsilibs::TIMING_HSI_FRAME_STRUCT>; RequestResult = dunedaq::readoutlibs::RequestHandlerConcept<dunedaq::hsilibs::TIMING_HSI_FRAME_STRUCT, dunedaq::readoutlibs::BinarySearchQueueModel<dunedaq::hsilibs::TIMING_HSI_FRAME_STRUCT> >::RequestResult] at /cvmfs/dunedaq-development.opensciencegrid.org/candidates/rc-v3.2.0-1/spack-0.18.1-gcc-12.1.0/spack-0.18.1/opt/spack/gcc-12.1.0/readoutlibs-rc-v3.2.0-1-k2fzlhldjutrnr5d4vjsnkz5i5bwtnjc/include/readoutlibs/models/detail/DefaultRequestHandlerModel.hxx:511] Returning partial fragment for trig/seq number 1.0 with TS 104034153929408170. Component subsystem: HW_Signals_Interface id: 0 with type Hardware_Signal
2022-Sep-30 15:01:03,862 LOG [typename dunedaq::readoutlibs::IterableQueueModel<T>::Iterator dunedaq::readoutlibs::BinarySearchQueueModel<T>::lower_bound(T&, bool) [with T = dunedaq::hsilibs::TIMING_HSI_FRAME_STRUCT; typename dunedaq::readoutlibs::IterableQueueModel<T>::Iterator = dunedaq::readoutlibs::IterableQueueModel<dunedaq::hsilibs::TIMING_HSI_FRAME_STRUCT>::Iterator] at /cvmfs/dunedaq-development.opensciencegrid.org/candidates/rc-v3.2.0-1/spack-0.18.1-gcc-12.1.0/spack-0.18.1/opt/spack/gcc-12.1.0/readoutlibs-rc-v3.2.0-1-k2fzlhldjutrnr5d4vjsnkz5i5bwtnjc/include/readoutlibs/models/detail/BinarySearchQueueModel.hxx:24] Could not find element

[roland-sipos]

Hi @strilov .
There was a window extraction logic change from @ShyamB97 and @alessandrothea .
Can you please check if thie patch fixes this issue?
0333e70

[strilov]

Hi @roland-sipos. I don't think the patch above will fix the issue. As far as I can see, the issue is in the lower_bound method of BinarySearchQueueModel, which gets called before the code modifications above.

This if statement, https://github.com/DUNE-DAQ/readoutlibs/blob/develop/include/readoutlibs/models/detail/BinarySearchQueueModel.hxx#L23, will always fail with the buffer parameters above, since by construction the start window ts is always lower than the trigger ts.