Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Placeholder_test should be replaced with real unit testing #19

Open
jcfreeman2 opened this issue Feb 28, 2024 · 0 comments
Open

The Placeholder_test should be replaced with real unit testing #19

jcfreeman2 opened this issue Feb 28, 2024 · 0 comments

Comments

@jcfreeman2
Copy link
Contributor

i.e., we should improve on line 61, the auto-generated skeleton unit test code created by create_dunedaq_package:

daq_add_unit_test(Placeholder_test LINK_LIBRARIES ${PROJECT_NAME})  # Placeholder_test should be replaced with real unit tests

Along with the benefits of unit testing, making this change will ensure that this can build in a work area even if other packages have this issue. Otherwise you'll see this error:

  target with the same name already exists.  The existing target is an
  executable created in source directory
  "/home/nfs/jcfree/daqbuild_feb27/sourcecode/hermesmodules".  See
  documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  crtmodules/CMakeLists.txt:49 (daq_add_unit_test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant