Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

feat(Endpoint): Implement WP76xx platform #718

Open
splasky opened this issue Jul 16, 2020 · 8 comments
Open

feat(Endpoint): Implement WP76xx platform #718

splasky opened this issue Jul 16, 2020 · 8 comments
Assignees
Labels
A-endpoint Area - Endpoint of tangle-accelerator C-feature Category - feature P-medium Priority - Medium, not hurry but needed S-blocked Status - This PR has been blocked

Comments

@splasky
Copy link
Contributor

splasky commented Jul 16, 2020

The FX30 gateway used the WP76xx platform. We should implement it.

@splasky splasky self-assigned this Jul 16, 2020
@splasky splasky added A-endpoint Area - Endpoint of tangle-accelerator C-feature Category - feature P-medium Priority - Medium, not hurry but needed labels Jul 16, 2020
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 16, 2020
This commit implement the WP76xx platform for the endpoint.

Close DLTcollab#718
@jserv
Copy link
Member

jserv commented Jul 16, 2020

Analyze the impact to existing HAL and adaption layer.

@jserv
Copy link
Member

jserv commented Jul 16, 2020

Never write code in a rush. Always think of the portability, code reusability, and elegance.

splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 24, 2020
This commit implement the WP76xx platform for the endpoint.

Close DLTcollab#718
@splasky
Copy link
Contributor Author

splasky commented Jul 27, 2020

The Legato AF provides the "simu" directory for generate test stub. The test stub can replace the HAL inside endpoint. So we only need one "impl.c" in endpoint for all platform. The HAL could be removed after the test passed(#707). However, when executed the endpoint binary. It will generate the error message "Failed to load library 'libComponent_endpointComp.so".

The attribute for different platform like wp77xx,wp76xx. We can set the attribute inside another definition files and import the setting when build the app for the target.

The test scripts for different platform like test-WP77.sh test-WP76.sh will be merged.
The build scripts for different platform will be merged.

splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 28, 2020
This commit implement the WP76xx platform for the endpoint.

Close DLTcollab#718
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 29, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 29, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 29, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 29, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 30, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
splasky added a commit to splasky/tangle-accelerator that referenced this issue Jul 30, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
@splasky
Copy link
Contributor Author

splasky commented Jul 31, 2020

After I tried to use the simu as platformService test stub provided by the Legato AF. It would raise some weird error during compiling. So I think it is better to define the simulator as test stub will be more easily.

But I think we won't need HAL anymore. We can define the impl.h for the platformService functions we need to use. And only need the simulator and the implementation for the device which legato target had already supported. Only need two platforms inside platform directory:

  • simulator: Acts as test stub
  • default: The platform had already supported by the Legato AF.

The test-WP77.sh should also change to test-legato-target.sh for test all the target on legato AF.
@jserv what do you think?

@jserv
Copy link
Member

jserv commented Jul 31, 2020

Check the subject. You mentioned WP76xx platform rather than the removal of HAL!

@jserv
Copy link
Member

jserv commented Jul 31, 2020

We should follow the steps:

  1. Decide the removal of HAL and validate simu substitute
  2. Adapt existing platforms for new interface;
  3. Documentation as possible;
  4. Support WP76xx;

@splasky
Copy link
Contributor Author

splasky commented Aug 3, 2020

The issue of removal of HAL will be moved to #707.

@splasky
Copy link
Contributor Author

splasky commented Aug 3, 2020

Block by #707

@splasky splasky added the S-blocked Status - This PR has been blocked label Aug 3, 2020
splasky added a commit to splasky/tangle-accelerator that referenced this issue Sep 22, 2020
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-endpoint Area - Endpoint of tangle-accelerator C-feature Category - feature P-medium Priority - Medium, not hurry but needed S-blocked Status - This PR has been blocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants