Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSACleanup not called #25

Open
BongoVR opened this issue Dec 15, 2021 · 0 comments
Open

WSACleanup not called #25

BongoVR opened this issue Dec 15, 2021 · 0 comments

Comments

@BongoVR
Copy link

BongoVR commented Dec 15, 2021

In CSimpleSocket::Initialize the m_hWSAData is initialised under Windows using WSAStartup.
According to MSDN, each call to WSAStartup must have a matching call to WSACleanup. However, the entire library is lacking such a call: https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-wsastartup

When frequently creating sockets, sending data, closing and destroying sockets, this might cause resource leaks.

Is this just an oversight?
Best regards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BongoVR