Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Is there way to fix already transformed exception with vanilla classes mixins when using this? #21

Open
iocmet opened this issue May 18, 2023 · 5 comments

Comments

@iocmet
Copy link

iocmet commented May 18, 2023

https://github.com/CrucibleMC/Grimoire-legacy/blob/legacy-1.7.10/src/main/java/io/github/crucible/grimoire/mixins/forge/MixinLoader.java
This is happening because mixins can't patch already loaded classes

@EverNife
Copy link
Member

If you are using GRIMOIRE-LEGACY!

https://github.com/CrucibleMC/Grimoire-Mixins-1.7.10/blob/master/Mixin-Forge/build.gradle#L13-L18

You can add the ""target minecraft classes"" by making the mixin a ""CORE_PATCH""

To do so, you need to add the info to the MAINFEST of the .jar

This is how you can do that https://github.com/CrucibleMC/Grimoire-Mixins-1.7.10/blob/master/Mixin-Forge/build.gradle#L13-L18

@iocmet
Copy link
Author

iocmet commented May 20, 2023

Im using this code from grimoire legacy (https://github.com/CrucibleMC/Grimoire-legacy/blob/legacy-1.7.10/src/main/java/io/github/crucible/grimoire/mixins/forge/MixinLoader.java) and i ran into problem that it says mod source duplication

@iocmet
Copy link
Author

iocmet commented May 20, 2023

If jar with mixins is mod this happening, is it grimoire issue?

@iocmet
Copy link
Author

iocmet commented May 20, 2023

I think it because of this but is there way to fix? i just want make mixin loader like in forge 1.15+ and fabric
image
image

@juanmuscaria
Copy link
Member

I would recommend using an already existing loader like https://github.com/Aizistral-Studios/Grimoire or https://github.com/LegacyModdingMC/UniMixins/
Otherwise you will run into issues of multiple loaders trying to achieve the same thing and clashing with each other. Grimoire-legacy is only here for historical reasons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants