add a hotkey for settings #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #942
That issue links multiple Human-Interface-Guidelines that suggest
CTRL+,(meta key and comma) as recommended for a Settings hotkey, so I used that.The keybinds extension uses a mix of classname and ID based button maps as its hotkey registration handling, so I matched that, using specifically a unique classname as that's easiest to apply directly (vs adding an ID requires also modifying SidebarIcon to support that). The old UI uses classname
comfy-settings-btnso I copied that to the new UI, allowing the hotkey to work the same on both UI variants.Worked in local testing, will add playwright test momentarily