Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.0] Beta menu rework / Model library sidebar tab / etc #960

Merged
merged 26 commits into from
Sep 25, 2024
Merged

Commits on Sep 25, 2024

  1. Floating menu option (#726)

    * Add floating menu
    
    * Fix
    
    * Updates
    
    * Add auto-queue change test
    
    * Fix
    pythongosssss authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    25300f2 View commit details
    Browse the repository at this point in the history
  2. Proxy ComfyWorkflow objects (#869)

    * Proxy ComfyWorkflow objects
    
    * nit
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    803f9e0 View commit details
    Browse the repository at this point in the history
  3. Move workflow dropdown to sidebar tab (#893)

    * Initial move to sidebar
    
    Remove broken CSS
    
    Move action buttons
    
    Migrate open workflows
    
    Add basic browse
    
    WIP
    
    Add insert support
    
    Remove legacy workflow manager
    
    Remove unused CSS
    
    Reorder
    
    Remove legacy workflow UI
    
    nit
    
    * Support bookmark
    
    Add workflow bookmark store
    
    nit
    
    Add back bookmark functionality
    
    Correctly load bookmarks
    
    nit
    
    Fix many other issues
    
    Fix this binding
    
    style divider
    
    * Extract tree leaf component
    
    * Hide bookmark section when no bookmarks
    
    * nit
    
    * Fix save
    
    * Add workflows searchbox
    
    * Add search support
    
    * Show total opened
    
    * Add basic test
    
    * Add more tests
    
    * Fix redo/undo test
    
    * Temporarily disable browser tab title test
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6ded7a3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e148cbf View commit details
    Browse the repository at this point in the history
  5. Fix routing and layout issue (#923)

    * fix router and move graph related parts to GraphView.vue
    
    * (fix) add back child element in UnloadWindowConfirmDialog
    
    * (cleanup) remove empty callback
    dmx974 authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ec5ba0c View commit details
    Browse the repository at this point in the history
  6. Revert "Fix routing and layout issue (#923)" (#930)

    This reverts commit 94db2e9.
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    729a521 View commit details
    Browse the repository at this point in the history
  7. Relands "Fix routing and layout issue" (#931)

    * Revert "Revert "Fix routing and layout issue (#923)" (#930)"
    
    This reverts commit 1e2dfea.
    
    * Fix merge conflicts
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c8e62bf View commit details
    Browse the repository at this point in the history
  8. Fix routing (#929)

    * fix router and move graph related parts to GraphView.vue
    
    * (fix) add back child element in UnloadWindowConfirmDialog
    
    * (cleanup) remove empty callback
    
    * (fix) routing issue when base url is not webroot
    
    * add back DEV_SERVER_COMFYUI_URL
    dmx974 authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    586a1ed View commit details
    Browse the repository at this point in the history
  9. Resolve merge conflict

    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bbe2de9 View commit details
    Browse the repository at this point in the history
  10. Remove support of Top/Bottom in menu positions (#933)

    * Remove support of Top/Bottom in menu positions
    
    * Update menu positions in test setting
    
    * nit
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b6dc11f View commit details
    Browse the repository at this point in the history
  11. Workflow templates (#938)

    * Add template gallery
    
    * Add simple test
    
    * Add examples
    
    * Enable floating menu in test
    pythongosssss authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    966834b View commit details
    Browse the repository at this point in the history
  12. [Draft] Model library sidebar tab (#837)

    * basic/empty model library sidebar tab
    
    in-progress
    
    * make it actually list out models
    
    * extremely primitive search impl
    
    * list out available folders
    
    (incomplete list atm)
    
    * load list dynamically
    
    * nice lil loading icon
    
    * that's not doing anything
    
    * run autoformatter
    
    * fix up some absolute vue shenanigans
    
    * swap to pi-box
    
    * is_fake_object
    
    * i think apply the tailwind thingo
    
    * trim '.safetensors' from end of display title
    
    * oop
    
    * after load, retain title if no new title is given
    
    * is_load_requested to prevent duplication
    
    * dirty initial model metadata load & preview
    
    based on node preview code
    
    * update model store tests
    
    * initial image icon for model lib
    
    * i hate this
    
    * better empty spacer
    
    * add api handler for '/models'
    
    * load model folders list instead of hardcoding
    
    * add a 'no content' placeholder for empty folders
    
    * autoformat
    
    * autoload model metadata
    
    * error handling on metadata loading
    
    * larger model icons
    
    * click a model to spawn a node for it
    
    * draggable model nodes
    
    * add a setting for whether to autoload or not
    
    * autoformat will be the death of me
    
    * cleanup promise code
    
    * make the model preview actually half-decent
    
    * revert bad unchecked change
    
    * put registration back
    mcmonkey4eva authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b9670a0 View commit details
    Browse the repository at this point in the history
  13. Add topbar dropdown menu (#937)

    * Add basic menu
    
    * Add workflows/edit to menu bar
    
    * Add command store
    
    * Fix z-index
    
    * Fix beta menu setting switch
    
    * nit
    
    * Drop to center
    
    * Fix command invocation
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    571d130 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8223241 View commit details
    Browse the repository at this point in the history
  15. don't show redundant model previews (#949)

    for #944
    mcmonkey4eva authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    63b7a1b View commit details
    Browse the repository at this point in the history
  16. Fix routing (#939)

    * reinstate working routing code and remove broken code
    
    * forward object_info
    
    * remove object_info bit
    mcmonkey4eva authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0b8acf4 View commit details
    Browse the repository at this point in the history
  17. Show opened workflows as topbar tabs (#952)

    * Basic tab switching
    
    * Closing tabs
    
    * Style buttons
    
    * wip
    
    * Fix scroll style
    
    * Add setting
    
    * Add playwright test
    
    * Add unsaved status
    
    * nit
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5f4e8ae View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    1463c0e View commit details
    Browse the repository at this point in the history
  19. better badges for empty/loading model library folders (#953)

    * better badges for empty/loading model library folders
    
    for #945
    
    * fix total count on loaded nodes
    
    * fix test break
    
    * additional test fix
    
    * use a null prop fallback instead of having to explicitly calc
    
    * patch
    mcmonkey4eva authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9bd4557 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    06136de View commit details
    Browse the repository at this point in the history
  21. initial download-folder-selector interface (#890)

    * initial download-folder-selector interface
    
    * use primevue select
    
    * add a folder select visibility checkbox
    
    * slightly reduce indirection
    
    * fix up select box updating
    
    * revert bad upstream changes
    
    * cleanup
    
    * allow localhost sourced models in ui side
    
    (for testing purposes only basically, but does no harm in deployed envs)
    
    * add screenshot expectations to test
    
    * Update test expectations [skip ci]
    
    * add testing of folder select
    
    * fix test
    
    * don't exclude folder selector when there's only 1
    
    since the checkbox covers that better anyway
    
    * oo - fix checkbox
    
    * Update test expectations [skip ci]
    
    * testing - don't expect screenshots :(
    
    * experimental new test code
    
    * toHaveClass is silly
    
    * add // comments documenting intent of allowedSources
    
    ---------
    
    Co-authored-by: github-actions <github-actions@github.com>
    2 people authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    36c3ecd View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    7d39581 View commit details
    Browse the repository at this point in the history
  23. Reduce SearchBox margins for lower resolutions. (#959)

    On lower screen widths, the SearchBox would scale itself down instead of
    reducing the fairly wide margins. This wastes space and has reduces the
    usability of the search box contents itself by cutting off information
    (such as the experimental badge) on nodes with medium or longer titles
    
    This is not without side effects, so further adjustments may be needed.
    Currently, the searchbox is slightly offset to the right even for wide
    screens and the adjustments are disabled for very small screens (<=768)
    such that the preview is offscreen, but the entirety of the searchbox is
    properly displayed down to 512
    AustinMroz authored and huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b3441b6 View commit details
    Browse the repository at this point in the history
  24. Rework queue button (#968)

    * Move queue button to right side
    
    * Rework split button
    
    * Group
    
    * Remove unused code
    
    * x2 buttons
    
    * Use primevue divider
    
    * adjust style
    
    * Add tooltip
    
    * Update test
    
    * Add clearing pending tasks button to queue bar
    
    * Fix state
    
    * Dropdown list fix
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c2a3f36 View commit details
    Browse the repository at this point in the history
  25. Reset FileInput value after load (#958)

    When a file is browsed for, the fileInput remains associated with the
    chosen file even after the associated workflow is loaded. If a user
    attempts to load the same file again, the onchange event does not fire
    and loading fails silently. This is fixed by clearing the fileInput
    after the workflow has been loaded.
    
    Out of an abundance of caution, the onchange is made async to ensure the
    fileInput isn't cleared until after the workflow has loaded.
    
    Add a test to check if the same workflow file can be loaded
    consecutively.
    AustinMroz committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c43bb20 View commit details
    Browse the repository at this point in the history
  26. Backward compatibility with extension injections on legacy menu bar (#…

    …970)
    
    * Compatible to legacy top menu extensions
    
    * Rework css
    
    * nit
    huchenlei committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2f7758f View commit details
    Browse the repository at this point in the history