Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement of success code: always 1, convert success code to int #6

Open
jdede opened this issue Jun 30, 2021 · 0 comments
Open

Improvement of success code: always 1, convert success code to int #6

jdede opened this issue Jun 30, 2021 · 0 comments
Labels
minor bug Bug which should be fixed but does not directly affect the functionality

Comments

@jdede
Copy link
Member

jdede commented Jun 30, 2021

The received success code is always 1 but should be different in case of a successful transmission, c.f.

WUSN/sources/MoleNet_1.0/MoleNet_node/MoleNet_node.ino

Line 143 in 66d6b34

//suc : success indicator 

//suc == '0' : crc-check and transmission failed
//suc == '1' : crc-check successful, but transmission failed
//suc == '2' : crc-check failed, transmission successful
//suc == '3' : crc-check and transmission successful

furthermore, the success code is handles as a char, not as an int.
@jdede jdede changed the title success code always 1, convert success code to int Improvement of success code: always 1, convert success code to int Jun 30, 2021
@jdede jdede added the minor bug Bug which should be fixed but does not directly affect the functionality label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor bug Bug which should be fixed but does not directly affect the functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdede