Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #26

Open
1 of 16 tasks
kwabenantim opened this issue Jul 18, 2023 · 0 comments
Open
1 of 16 tasks

Housekeeping #26

kwabenantim opened this issue Jul 18, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kwabenantim
Copy link
Member

kwabenantim commented Jul 18, 2023

Description
Tidy up repository.

To Do

  • Remove unused files/directories such as:
    • dynamic/wrapper_generators/generate_wrapper_code_old.py
    • dynamic/wrappers/preload/
    • .travis.yml
    • Everything in infra/conda except chaste, vtk, and xsd because most dependencies are now on conda-forge.
    • apps/
    • src/tutorial/
    • doc/tutorials/Python/TestCellSorting/results_from_time_0
    • doc/tutorials/.ipynb_checkpoints/
  • Clean up code:
    • Remove namespace py=pybind11 etc. from headers.
    • Add #include <pybind11/pybind11.h> in headers.
    • Group and sort includes.
    • Do code formatting.
    • Fix wrapper guard naming e.g. AbstractCaUpdateRule3_hpp__pyplusplus_wrapper doesn't correspond to filename AbstractCaUpdateRule3.cppwg.hpp, and pyplusplus is no longer used for wrapper generation.
    • To clarify purpose of typedefs, use only where required e.g. typedef AbstractCaUpdateRule<2> AbstractCaUpdateRule2 is necessary for the PYBIND11_OVERLOAD macro but not elsewhere.
@kwabenantim kwabenantim added the enhancement New feature or request label Jul 18, 2023
@kwabenantim kwabenantim self-assigned this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant