Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halflife skips many posts #5

Open
tripleee opened this issue Jun 6, 2018 · 9 comments
Open

Halflife skips many posts #5

tripleee opened this issue Jun 6, 2018 · 9 comments

Comments

@tripleee
Copy link
Member

tripleee commented Jun 6, 2018

When two or more posts are reported in rapid succession, the second and subsequent posts are sometimes missed by Halflife.

Searching for tagged/skipped shows many such incidents.

I originally thought this was a problem with Metasmoke, but in fact, it's probably a bug in Halflife. It should pick up the websocket again quickly after a message is received in order to keep on listening properly.

Moving to async processing would probably fix this. (#2 #1)

@tripleee
Copy link
Member Author

Not sure if this is really a problem; at least the vast majority of cases are when the same post is reported multiple times.

@tripleee
Copy link
Member Author

tripleee commented Mar 8, 2019

Still this happens occasionally because (I think) the websocket polling is not async / threaded and so it misses whatever comes in while we are scanning the previous message.

@double-fault
Copy link
Member

I'm not really sure on how Halflife works, but are you sure the messages are not being throttled?

@tripleee
Copy link
Member Author

tripleee commented Mar 9, 2019

This is listening to Metasmoke's ActionCable websocket; pretty sure there is no throttling there, but maybe I should investigate that, too.

Sent with GitHawk

@double-fault
Copy link
Member

double-fault commented Mar 9, 2019

Uh, I meant throttling with the chat interface, ChatExchange. Messages posted in quick succession get throttled by SE.

@tripleee
Copy link
Member Author

tripleee commented Mar 9, 2019

Halflife doesn't chat at all, it just leaves its output in a log file which is then published on another websocket for PulseMonitor to eventually push to chat. (This does suffer significantly from chat throttling, but it's not a problem in Halflife. You can listen to the raw websocket to get a feel for how much additional overhead chat incurs.)

Sent with GitHawk

@double-fault
Copy link
Member

Sorry, looks like my message was not clear enough; I was originally attempting to ask whether the messages have just been missed in chat (i.e, it is a PM problem), or have you seen them missing in the ws log.

Looks like the messages are missing in the log itself, so it is a Halflife problem indeed.

@tripleee
Copy link
Member Author

tripleee commented Mar 5, 2020

The "skipped" notices seem to belong to posts which were reported more than once. I guess Metasmoke doesn't generate an event in that case (or the event is in a different form which the bot doesn't register it). Maybe this could be closed.

@tripleee
Copy link
Member Author

Also, the ActionCable client only subscribes to "created" notices, so it will not receive notices of updated posts. I'll look into changing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants