Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Find Service with multicast enabled, vsomeip stack always send unicast offer service #753

Open
SarbeenaS opened this issue Aug 13, 2024 · 1 comment
Labels

Comments

@SarbeenaS
Copy link

vSomeip Version

v3.4.10

Boost Version

1.76

Environment

Ubuntu and Android

Describe the bug

Find Service with multicast enabled, vsomeip stack always send unicast offer service
Find_Unicast

Reproduction Steps

No response

Expected behaviour

No response

Logs and Screenshots

No response

@SarbeenaS SarbeenaS added the bug label Aug 13, 2024
@vidz12
Copy link

vidz12 commented Aug 22, 2024

Below two changes are done in service_discovery_impl class,

image (9)

  1. In send_uni_or_multicast_offerservice() function,
    send_multicast_offer_service(_info) is added if unicast_flag comes with value 0

  2. In send_multicast_offer_service function,
    serialize_and_send() is modified to accept sd_multicast_address_ as address param.

And it is working for us.
i.e. OFFER() is sent over multicast when FIND() is triggered with UNICAST flag set as 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants