Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVIEW ME - Bump gson from 2.9.1 to 2.10 #265

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2022

Bumps gson from 2.9.1 to 2.10.

Release notes

Sourced from gson's releases.

Gson 2.10

Most important changes

  • Support for serializing and deserializing Java records, on Java ≥ 16. (#2201)

  • Add JsonArray.asList and JsonObject.asMap view methods (#2225)

  • Fix TypeAdapterRuntimeTypeWrapper not detecting reflective TreeTypeAdapter and FutureTypeAdapter (#1787)

  • Improve JsonReader.skipValue() (#2062)

  • Perform numeric conversion for primitive numeric type adapters (#2158)

  • Add Gson.fromJson(..., TypeToken) overloads (#1700)

  • Fix changes to GsonBuilder affecting existing Gson instances (#1815)

  • Make JsonElement conversion methods more consistent and fix javadoc (#2178)

  • Throw UnsupportedOperationException when JsonWriter.jsonValue is not supported (#1651)

  • Disallow JsonObject Entry.setValue(null) (#2167)

  • Fix TypeAdapter.toJson throwing AssertionError for custom IOException (#2172)

  • Convert null to JsonNull for JsonArray.set (#2170)

  • Fixed nullSafe usage. (#1555)

  • Validate TypeToken.getParameterized arguments (#2166)

  • Fix #1702: Gson.toJson creates CharSequence which does not implement toString (#1703)

  • Prefer existing adapter for concurrent Gson.getAdapter calls (#2153)

  • Improve ArrayTypeAdapter for Object[] (#1716)

  • Improve AppendableWriter performance (#1706)

List of all changes

... (truncated)

Changelog

Sourced from gson's changelog.

Change Log

Commits
  • dd92e49 [maven-release-plugin] prepare release gson-parent-2.10
  • 7ca36c5 Add a \<developers> section to the main pom.xml.
  • 79c27dd [maven-release-plugin] prepare for next development iteration
  • 87e9ee5 [maven-release-plugin] prepare release gson-parent-2.10
  • 4705518 Revise the version regex in GsonVersionDiagnosticsTest. (#2228)
  • 7bca5c4 [maven-release-plugin] rollback the release of gson-parent-2.10
  • c7544a0 [maven-release-plugin] prepare for next development iteration
  • 9efdfad [maven-release-plugin] prepare release gson-parent-2.10
  • 4f948dd Automatically replace version references on release:prepare (#2212)
  • 9578583 Small tweaks to fix Error Prone warnings. (#2227)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 26, 2022
@SIMULATAN SIMULATAN changed the title Bump gson from 2.9.1 to 2.10 REVIEW ME - Bump gson from 2.9.1 to 2.10 Oct 26, 2022
@SIMULATAN
Copy link
Member

DONT merge this yet!

We currently have a dependency for the record-type-adapter from Marcono, which seems to be made obsolete in this version. Please migrate the project to the built-in way (+remove the dependency), and verify that it works as expected.

TODO for me: if it actually does replace Marconos Project, open an issue on their GitHub

@SIMULATAN SIMULATAN added the blocked Blocked due to pr label Oct 26, 2022
@SIMULATAN SIMULATAN self-assigned this Oct 26, 2022
@RealYusufIsmail
Copy link
Member

Why do use gson anyways why don't you use Jackson

@SIMULATAN
Copy link
Member

Why do use gson anyways why don't you use Jackson

I started out with gson and never really learned anything else

@RealYusufIsmail
Copy link
Member

Ah ok

@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.code.gson-gson-2.10 branch 8 times, most recently from 9e2b9d5 to 1d647d9 Compare November 15, 2022 06:46
@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.code.gson-gson-2.10 branch 2 times, most recently from 07a5144 to 312b5c5 Compare November 19, 2022 09:06
@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.code.gson-gson-2.10 branch from 312b5c5 to 9f46548 Compare December 27, 2022 10:19
Bumps [gson](https://github.com/google/gson) from 2.9.1 to 2.10.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](google/gson@gson-parent-2.9.1...gson-parent-2.10)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/com.google.code.gson-gson-2.10 branch from 9f46548 to f279b1b Compare December 27, 2022 14:54
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2023

Superseded by #301.

@dependabot dependabot bot closed this Jan 9, 2023
@dependabot dependabot bot deleted the dependabot/gradle/com.google.code.gson-gson-2.10 branch January 9, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked due to pr dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants