Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible Issue / Missing Aria-Label for input field #2825

Closed
masteradhoc opened this issue May 29, 2024 · 1 comment
Closed

Accessible Issue / Missing Aria-Label for input field #2825

masteradhoc opened this issue May 29, 2024 · 1 comment

Comments

@masteradhoc
Copy link
Contributor

Describe the bug
The following line seems to be missing an aria-label. Gets flagged by tools like https://wave.webaim.org/

<input type="text" name="search_keywords" id="search_keywords" placeholder="<?php esc_attr_e( 'Keywords', 'wp-job-manager' ); ?>" value="<?php echo esc_attr( $keywords ); ?>" />

Screenshots
image

Expected behavior

  1. Field should have a aria-label
  2. String should be translateable
@mikeyarce
Copy link
Member

There are labels there for the fields, so this looks like a false positive.

<div class="search_keywords">
<label for="search_keywords"><?php esc_html_e( 'Keywords', 'wp-job-manager' ); ?></label>
<input type="text" name="search_keywords" id="search_keywords" placeholder="<?php esc_attr_e( 'Keywords', 'wp-job-manager' ); ?>" value="<?php echo esc_attr( $keywords ); ?>" />
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants