Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give proper error messages when parsing improper AtlasImport file. #1495

Open
hanjoosten opened this issue Aug 13, 2024 · 1 comment
Open
Assignees

Comments

@hanjoosten
Copy link
Member

For the Atlas import, a JSON file is generated by the Atlas. However, there can be issues with the generated file. I.e, the name of a concept cannot be any string. It must abide to the rules for a name.
Currently, when this happens, a fatal is thrown. The JSON parser should be refactored, so it doesn't result in a P_Context, but in a Guarded P_Context.

@hanjoosten hanjoosten self-assigned this Aug 13, 2024
@hanjoosten
Copy link
Member Author

The parsing of the .json file, generated by the Atlas, has been modified. It now returns proper error messages. However, in doing so, the special command to cope with the .json file has been abandoned. Any file that is given to the parser of Ampersand, that has the extention .json, will be parsed by the conventions of the Atlas. Such file could now even be INCLUDE-d in other scripts.
@SimonvRoozendaalOrdina , instead of using the AtlasImport utility, you now can use the check command and the export command. Use the .json file as the input script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant