Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell script should offer specification of output filename #242

Closed
cortner opened this issue Sep 10, 2024 · 9 comments
Closed

Shell script should offer specification of output filename #242

cortner opened this issue Sep 10, 2024 · 9 comments

Comments

@cortner
Copy link
Member

cortner commented Sep 10, 2024

Currently the shell script works as follows

julia --project=. runfit.jl -p model_spec.json

with the output file specified in model_spec.json. There should be another argument that overrides the output file spec, e.g.

julia --project=. runfit.jl -p model_spec.json -o result.json
@cortner
Copy link
Member Author

cortner commented Sep 11, 2024

@iamveronika -- could you make a PR that adresses this?

@cortner
Copy link
Member Author

cortner commented Sep 12, 2024

maybe coordinate with @CheukHinHoJerry - to see how he envisions using the runfit script.

@CheukHinHoJerry
Copy link
Collaborator

CheukHinHoJerry commented Sep 12, 2024

julia --project=. runfit.jl -p model_spec.json -o result_folder seems to be the best for me, and then maybe primarily in the output section of model_spec.json we can support a few easy tests

  "output": {
    "model": "opted_model",
    "dimer": false,
    "error_table": true,
    "scatter_error": false
  }

and we output everything into result_folder together with the data needed to reproduce those plots in a result_folder/result.json file.

@cortner
Copy link
Member Author

cortner commented Sep 12, 2024

and maybe the default model filename can just be model.json, unless otherwise specified in the model specification dictionary?

@cortner
Copy link
Member Author

cortner commented Sep 12, 2024

I think something like this will be great.

@cortner
Copy link
Member Author

cortner commented Sep 12, 2024

and can we take a default output folder to be result_model_spec where model_spec is the input filename? (of -o is not specified)

@CheukHinHoJerry
Copy link
Collaborator

yes same thought, i will create a PR after finishing this items.

@cortner
Copy link
Member Author

cortner commented Sep 12, 2024

great, please make sure to merge latest main into your branch.

@cortner
Copy link
Member Author

cortner commented Sep 13, 2024

Now addressed by #254

@cortner cortner closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants